From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38227)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1V6K95-0008PW-UH
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:44:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1V6K91-00006H-GQ
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:44:19 -0400
Received: from mail-lb0-f182.google.com ([209.85.217.182]:35030)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1V6K91-00005e-A7
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 08:44:15 -0400
Received: by mail-lb0-f182.google.com with SMTP id v20so2069306lbc.27
	for <qemu-devel@nongnu.org>; Mon, 05 Aug 2013 05:44:14 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAAhSdy1sCdzFKYJG+v2GM16Pf+hs1ZKk-ShEvcQyPkpeafL2xQ@mail.gmail.com>
References: <1375701492-21759-1-git-send-email-peter.maydell@linaro.org>
	<1375701492-21759-3-git-send-email-peter.maydell@linaro.org>
	<CAAhSdy2bkSVYgpB-xRk8-7nNwuSE0ai=oqOvyTL15pAqa921-Q@mail.gmail.com>
	<CAFEAcA9xE7CoiwXN09uNpU6c2c0hOrGQQkBJzZTLyUj26QR51w@mail.gmail.com>
	<CAAhSdy3XvG2zKMXr2N=jC3HX8OQeY9LjvCpXCw3VA9UrxYuATw@mail.gmail.com>
	<CAFEAcA-XoB5wy_=L7fDyN1BzG0FgBU8d4wyXLxSBYSUtHEY2qA@mail.gmail.com>
	<CAAhSdy1sCdzFKYJG+v2GM16Pf+hs1ZKk-ShEvcQyPkpeafL2xQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 5 Aug 2013 13:43:54 +0100
Message-ID: <CAFEAcA9yGhp_u4RkfzPAkhALfq2+0b4A8s2Goh6=8ej0EmW13A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 2/2] ARM: Add 'virt' platform
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anup Patel <anup@brainfault.org>
Cc: "patches@linaro.org" <patches@linaro.org>, qemu-devel@nongnu.org, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On 5 August 2013 13:37, Anup Patel <anup@brainfault.org> wrote:
> On Mon, Aug 5, 2013 at 5:58 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> I really don't want to eat 2MB for each virtio-mmio transport
>> in a 32 bit address space, it seems hugely wasteful unless
>> there's a good reason to do it.
>
> I am not suggesting to give 2MB space to each virtio-mmio transport.
>
> What I really meant was to start VIRT_MMIO space (where all the
> virtio-mmio transport would be added) to start at 2MB aligned address
> and have total size (include all virtio-mmio transports) to be in-multiple
> of 2MB so that we can trap access to all virtio-mmio transports using
> 1-2 2MB entries in Stage2.

Yes, that's fine. That would give us:

static const MemMapEntry a15memmap[] = {
    [VIRT_FLASH] = { 0, 0x1000000 },
    [VIRT_CPUPERIPHS] = { 0x1000000, 0x8000 },
    /* GIC distributor and CPU interfaces sit inside the CPU peripheral space */
    [VIRT_GIC_DIST] = { 0x1001000, 0x1000 },
    [VIRT_GIC_CPU] = { 0x1002000, 0x1000 },
    [VIRT_MMIO] = { 0x1200000, 0x200 },
    /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */
    [VIRT_MEM] = { 0x8000000, 30ULL * 1024 * 1024 * 1024 },
};

-- PMM