From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Cao jin <caoj.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] Xen: fix converity warning of xen_pt_config_init()
Date: Thu, 11 Aug 2016 19:11:40 +0100 [thread overview]
Message-ID: <CAFEAcA9yc01coB89Qxmk3pjeUj7zm0sX0XG74iisAZDYWVTcgA@mail.gmail.com> (raw)
In-Reply-To: <1453724163-26353-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Hi Stefano -- just a ping on this patch from January -- I have a feeling
it maybe got lost in your change of email address?
(I noticed looking through coverity reports that this one was unfixed
and found Cao Jin's patch in the list archive.)
thanks
-- PMM
On 25 January 2016 at 12:16, Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> emu_regs is a pointer, ARRAY_SIZE doesn't return what we expect.
> Since the remaining message is enough for debugging, so just remove it.
> Also tweaked the message a little.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/xen/xen_pt_config_init.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
> index 81c6721..e505438 100644
> --- a/hw/xen/xen_pt_config_init.c
> +++ b/hw/xen/xen_pt_config_init.c
> @@ -2047,9 +2047,8 @@ void xen_pt_config_init(XenPCIPassthroughState *s, Error **errp)
> for (j = 0; regs->size != 0; j++, regs++) {
> xen_pt_config_reg_init(s, reg_grp_entry, regs, &err);
> if (err) {
> - error_append_hint(&err, "Failed to initialize %d/%zu"
> - " reg 0x%x in grp_type = 0x%x (%d/%zu)",
> - j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs),
> + error_append_hint(&err, "Failed to init register %d"
> + " offsets 0x%x in grp_type = 0x%x (%d/%zu)", j,
> regs->offset, xen_pt_emu_reg_grps[i].grp_type,
> i, ARRAY_SIZE(xen_pt_emu_reg_grps));
> error_propagate(errp, err);
> --
> 2.1.0
next prev parent reply other threads:[~2016-08-11 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 12:16 [Qemu-devel] [PATCH] Xen: fix converity warning of xen_pt_config_init() Cao jin
2016-08-11 18:11 ` Peter Maydell [this message]
2016-08-11 19:18 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9yc01coB89Qxmk3pjeUj7zm0sX0XG74iisAZDYWVTcgA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.