All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	"patches@linaro.org" <patches@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments
Date: Thu, 7 Jun 2018 14:25:52 +0100	[thread overview]
Message-ID: <CAFEAcA9z=f9oiqYrF8ZeCMj9-FjZAyMMGwv9e-argF+vRd4X-g@mail.gmail.com> (raw)
In-Reply-To: <20180607124016.GJ19032@stefanha-x1.localdomain>

On 7 June 2018 at 13:40, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Jun 04, 2018 at 07:17:56PM -0600, Alex Williamson wrote:
>> Note that the kernel coding style, except for certain exceptions, is:
>>
>> /*
>>  * This is a
>>  * multi-line
>>  * comment
>>  */
>
> Amen, the one true way.  :-)

OK, consensus seems to be for recommending the kernel-style for
multiline comments.

Does anybody who knows checkpatch feel like they could write a
checkpatch check for this? (Unfortunately there isn't one in
the kernel's checkpatch script either, as I found out when I
last wrote a kernel patch and got dinged for not putting that
first blank line in...)

thanks
-- PMM

      reply	other threads:[~2018-06-07 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 16:21 [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments Peter Maydell
2018-06-04 18:01 ` John Snow
2018-06-04 19:10 ` Philippe Mathieu-Daudé
2018-06-05  1:17 ` Alex Williamson
2018-06-05  4:33   ` Thomas Huth
2018-06-05  7:46     ` Cornelia Huck
2018-06-05  9:19       ` Peter Maydell
2018-06-05  9:49         ` Thomas Huth
2018-06-05  9:55         ` Cornelia Huck
2018-06-07 12:02         ` Markus Armbruster
2018-06-11 11:22           ` Kevin Wolf
2018-06-07 12:40   ` Stefan Hajnoczi
2018-06-07 13:25     ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9z=f9oiqYrF8ZeCMj9-FjZAyMMGwv9e-argF+vRd4X-g@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.