All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: qemu Developers <qemu-devel@nongnu.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues
Date: Tue, 22 Feb 2022 17:15:22 +0000	[thread overview]
Message-ID: <CAFEAcA_-tP_ecJtUx3BNwUGEGHTZ_tYv=YC65_paCucD_ryjOQ@mail.gmail.com> (raw)
In-Reply-To: <CAMVc7JXkQo4XYhuYHN91h7Sr+60HQkp4gKQSH=QH=yg3JSjz3g@mail.gmail.com>

On Tue, 22 Feb 2022 at 17:13, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> On Wed, Feb 23, 2022 at 2:06 AM Peter Maydell <peter.maydell@linaro.org> wrote:
> > diff --git a/ui/cocoa.m b/ui/cocoa.m
> > index a8f1cdaf926..f8d3d8ad7a6 100644
> > --- a/ui/cocoa.m
> > +++ b/ui/cocoa.m
> > @@ -522,8 +522,9 @@ QemuCocoaView *cocoaView;
> >      }
> >  }
> >
> > -- (void) updateUIInfo
> > +- (void) doUpdateUIInfo
>
> You may add the suffix "Locked" to align with handleEventLocked and
> make the intention more explicit.

Ah, good idea.

> > +    /* Now we're set up, tell the UI layer our initial window size */
> > +    dispatch_async(dispatch_get_main_queue(), ^{
> > +        [cocoaView updateUIInfo];
> > +    });
> >  }
>
> This is not necessary since register_displaychangelistener calls dpy_gfx_switch.

Cool, I'll drop this bit.

-- PMM


  reply	other threads:[~2022-02-22 17:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 17:06 [PATCH 0/2] ui/cocoa: updateUIInfo threading, autorelease pools Peter Maydell
2022-02-22 17:06 ` [PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues Peter Maydell
2022-02-22 17:13   ` Akihiko Odaki
2022-02-22 17:15     ` Peter Maydell [this message]
2022-02-22 17:06 ` [PATCH 2/2] ui/cocoa.m: Remove unnecessary NSAutoreleasePools Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_-tP_ecJtUx3BNwUGEGHTZ_tYv=YC65_paCucD_ryjOQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=akihiko.odaki@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.