All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Riku Voipio <riku.voipio@iki.fi>,
	Chen Gang S <gang.chen@sunrus.com.cn>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user/main.c: Use TARGET_SIG* instead of SIG*
Date: Tue, 27 Jan 2015 15:49:09 +0000	[thread overview]
Message-ID: <CAFEAcA_0AJNCkhRwm5B1KroDRaF2ks-n3wf09tQzKTeOqNRHnQ@mail.gmail.com> (raw)
In-Reply-To: <54C7B30D.4060204@msgid.tls.msk.ru>

On 27 January 2015 at 15:47, Michael Tokarev <mjt@tls.msk.ru> wrote:
> 25.01.2015 14:35, Chen Gang S wrote:
>> In main.c, all SIG* need be change to TARGET_SIG*, since the related
>> next call are all for TARGET_SIG*: queue_signal() and gdb_handlesig().
>
> In main.c, all SIG* should be TARGET_SIG*, since the relevant functions
> (queue_signal() and gdb_handlesig()) expects TARGET_SIG*.

"expect", if you want to be picky about the grammar...

-- PMM

      reply	other threads:[~2015-01-27 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-25 11:35 [Qemu-devel] [PATCH] linux-user/main.c: Use TARGET_SIG* instead of SIG* Chen Gang S
2015-01-25 12:44 ` Peter Maydell
2015-01-27 15:47 ` Michael Tokarev
2015-01-27 15:49   ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_0AJNCkhRwm5B1KroDRaF2ks-n3wf09tQzKTeOqNRHnQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=gang.chen@sunrus.com.cn \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.