From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrCjg-0001VO-20
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrCjd-0000h1-Rm
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:43:03 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:39533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SrCjd-0000fI-K7
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 14:43:01 -0400
Received: by bkcji1 with SMTP id ji1so655595bkc.4
	for <qemu-devel@nongnu.org>; Tue, 17 Jul 2012 11:43:00 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1342377272-32511-1-git-send-email-sw@weilnetz.de>
References: <1342377272-32511-1-git-send-email-sw@weilnetz.de>
Date: Tue, 17 Jul 2012 19:43:00 +0100
Message-ID: <CAFEAcA_2JF74_TwkKdCM69KqPm8L6qmj1TkxJTAXzeuh9pFheA@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by
 standard shell code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 15 July 2012 19:34, Stefan Weil <sw@weilnetz.de> wrote:
> "+=" does not work with dash and other simple /bin/sh implementations.
>
> The new code prepends the flag while the old code either did not work
> (it continued after an error message which typically was not read) or
> appended the flag. That difference should not matter here.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 12351f5..0269ba0 100755
> --- a/configure
> +++ b/configure
> @@ -2822,7 +2822,7 @@ int main(int argc, char **argv)
>  }
>  EOF
>    if ! compile_prog "" "" ; then
> -    CFLAGS+="-march=i486"
> +    CFLAGS="-march=i486 $CFLAGS"
>    fi
>  fi

This is not quite the right fix for this. This flag should be in
QEMU_CFLAGS, because it is a flag without which QEMU
would be unable to compile. See previous discussion in this
thread:

http://lists.xen.org/archives/html/xen-devel/2012-04/msg00330.html

(Unfortunately Olaf never submitted an updated patch.)

-- PMM