From: Peter Maydell <peter.maydell@linaro.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Xuzhou Cheng <xuzhou.cheng@windriver.com>,
Bin Meng <bin.meng@windriver.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Jean-Christophe Dubois <jcd@tribudubois.net>,
qemu-arm <qemu-arm@nongnu.org>,
Peter Chubb <peter.chubb@nicta.com.au>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 2/2] hw/ssi: imx_spi: Disable chip selects in imx_spi_reset()
Date: Fri, 8 Jan 2021 16:00:40 +0000 [thread overview]
Message-ID: <CAFEAcA_2Qe8PW3A-4Ff+HvbR+A5ACOg3upPUQvSMZ-GuQQg-rA@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmVsjNAm+arSskKJx5LCCKbcpHyRJr+SO6wY_8mE-P37Og@mail.gmail.com>
On Fri, 8 Jan 2021 at 15:55, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Fri, Jan 8, 2021 at 10:40 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> > Calling qemu_set_irq() in a device reset function is a bad
> > idea, because you don't know whether the thing on the other
> > end of the IRQ line (a) has already reset before you or
> > (b) is going to reset after you. If you need to do this then
> > I think you need to convert this device (and perhaps whatever
> > it's connected to) to the 3-phase-reset API. (But you probably
> > don't, see below.)
> >
>
> Thanks for the review. What about the imx_spi_update_irq() in the
> imx_spi_reset()? Should we remove that from the imx_spi_reset() as
> well?
Yes, I think so.
thanks
-- PMM
next prev parent reply other threads:[~2021-01-08 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 14:45 [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported Bin Meng
2020-12-02 14:45 ` [PATCH v2 2/2] hw/ssi: imx_spi: Disable chip selects in imx_spi_reset() Bin Meng
2021-01-08 14:40 ` Peter Maydell
2021-01-08 15:55 ` Bin Meng
2021-01-08 16:00 ` Peter Maydell [this message]
2020-12-16 10:24 ` [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported Bin Meng
2020-12-22 6:24 ` Bin Meng
2020-12-30 23:51 ` Bin Meng
2021-01-05 21:08 ` Alistair Francis
2021-01-05 21:10 ` Peter Maydell
2021-01-06 0:22 ` Bin Meng
2021-01-06 6:05 ` Bin Meng
2021-01-05 21:12 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_2Qe8PW3A-4Ff+HvbR+A5ACOg3upPUQvSMZ-GuQQg-rA@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=jcd@tribudubois.net \
--cc=peter.chubb@nicta.com.au \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=xuzhou.cheng@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.