From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwARR-0003nW-3M for qemu-devel@nongnu.org; Thu, 06 Apr 2017 12:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwARQ-000179-E4 for qemu-devel@nongnu.org; Thu, 06 Apr 2017 12:39:25 -0400 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:34037) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwARQ-00016S-7e for qemu-devel@nongnu.org; Thu, 06 Apr 2017 12:39:24 -0400 Received: by mail-wr0-x235.google.com with SMTP id t20so71269188wra.1 for ; Thu, 06 Apr 2017 09:39:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <30f2db0a-2132-4f6e-cd06-f5505f01db88@amsat.org> References: <1491486340-25988-1-git-send-email-peter.maydell@linaro.org> <30f2db0a-2132-4f6e-cd06-f5505f01db88@amsat.org> From: Peter Maydell Date: Thu, 6 Apr 2017 17:39:02 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm: Add missing entries to excnames[] for log strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-arm , QEMU Developers , "patches@linaro.org" On 6 April 2017 at 17:34, Philippe Mathieu-Daud=C3=A9 wro= te: > Hi Peter, > > excnames[] is only used in arm_log_exception(), can we move it there? Seems like a good idea. I think this is historic, we used to use it in separate functions in different files for the 32-bit and 64-bit exception entry code, but those got unified a little while back. I'll do that as a separate patch, though. thanks -- PMM