From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914F0C433B4 for ; Fri, 14 May 2021 16:53:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E00261440 for ; Fri, 14 May 2021 16:53:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E00261440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhb3l-0001tP-2p for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 12:53:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhanC-000572-A3 for qemu-devel@nongnu.org; Fri, 14 May 2021 12:36:02 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:40716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhanA-0002Pa-LQ for qemu-devel@nongnu.org; Fri, 14 May 2021 12:36:01 -0400 Received: by mail-ed1-x52b.google.com with SMTP id t3so2896008edc.7 for ; Fri, 14 May 2021 09:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gXR9v9YzHwcopV9q9OZmec3AydXQAi8HgzmK/QJbosQ=; b=EfF6R44AVT7Wa6CwF2Icpd2Cr0N/heuCjTOnUYfhvEr3Zn4pHZAtkJlCxHP85zZJte tCrACkMdOS+C2gdPw1TunXEuNXrhMeIvHPsz+Xyje2MvUHNZB7HqdT0H0/Yzc+cVgdgy NS3auTeFNtG/ilgdbGpuuyt0VhLdksayFzxq4v+7vp1pKo00lxZlonNtXaC/G5E/5qzV iS71l8eM6hghxUoteZPSA2oR3JKPep6mat7kmVRsPcece8QnJmup6zZqpSwBdfIkBdIs C3YzZIIe9DwhQtoIkZ/A/rR3+KXJJqNTWtiCK9aq2QF0tBWqL+dWx1Tj/Mqjz7e7M4FR pjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gXR9v9YzHwcopV9q9OZmec3AydXQAi8HgzmK/QJbosQ=; b=jtBAnOGdXeXgEQaeZRdUYy4p8h5tYZkkH6VupV28NqwJSFdo+5009uD23iGtBTbolF u46FQHH0jwa3HX5rl1Jl7DOH9a/YTE1O7D0xv+ba4iOomSABNn0EQiEqICRk6bDK/ND6 3tGVihf4R5MGz+QEMK5wF6TzEGAyw5SOSVeFdBThVFwQ3W1lNGVNPPWhwxxp1vWgcnP3 ONINNdX6LFSOfQshvMfvzgalvXu8WJdwkmuMFWiwpcsuh/3dwoaqrbC2lnMS7O+br0Fo 82vE4RYvLmHSRHx4FUhWsWEvToja/zI8H2MUJaE1zKwkchJnii36iBH+ufJY7h8PXSYM aJAQ== X-Gm-Message-State: AOAM533cEVYHhvn0KpG0X78/WmWD99nGnhab/zJBVc9mBMU336bNBA6b +mja6CYuLr8beOibYXh3UNDZSSd3DDNPWRKDMTMDFg== X-Google-Smtp-Source: ABdhPJxUIYhHc5tSuhAkqqbEtZ25QKf90/8QaBCjjZSRoXziQ/MCRrcTABxw9I/3oJeLBYixOm+4+G7YGWQU/+lGfy4= X-Received: by 2002:a50:ab06:: with SMTP id s6mr48322939edc.100.1621010159186; Fri, 14 May 2021 09:35:59 -0700 (PDT) MIME-Version: 1.0 References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-49-richard.henderson@linaro.org> <6df073b6-f65a-d9f7-1942-178875c2699f@linaro.org> In-Reply-To: <6df073b6-f65a-d9f7-1942-178875c2699f@linaro.org> From: Peter Maydell Date: Fri, 14 May 2021 17:35:46 +0100 Message-ID: Subject: Re: [PATCH v6 48/82] target/arm: Pass separate addend to {U, S}DOT helpers To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 14 May 2021 at 17:33, Richard Henderson wrote: > > On 5/13/21 5:47 AM, Peter Maydell wrote: > > On Fri, 30 Apr 2021 at 21:57, Richard Henderson > > wrote: > >> > >> For SVE, we potentially have a 4th argument coming from the > >> movprfx instruction. Currently we do not optimize movprfx, > >> so the problem is not visible. > >> > >> Signed-off-by: Richard Henderson > >> --- > >> v4: Fix double addition (zhiwei). > >> --- > >> target/arm/helper.h | 20 +++--- > >> target/arm/sve.decode | 7 ++- > >> target/arm/translate-a64.c | 15 ++++- > >> target/arm/translate-neon.c | 10 +-- > >> target/arm/translate-sve.c | 13 ++-- > >> target/arm/vec_helper.c | 120 ++++++++++++++++++++---------------- > >> 6 files changed, 109 insertions(+), 76 deletions(-) > > > >> diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c > >> index a3d80ecad0..f88e572132 100644 > >> --- a/target/arm/vec_helper.c > >> +++ b/target/arm/vec_helper.c > >> @@ -375,71 +375,76 @@ void HELPER(sve2_sqrdmlsh_d)(void *vd, void *vn, void *vm, > >> * All elements are treated equally, no matter where they are. > >> */ > >> > >> -void HELPER(gvec_sdot_b)(void *vd, void *vn, void *vm, uint32_t desc) > >> +void HELPER(gvec_sdot_b)(void *vd, void *vn, void *vm, void *va, uint32_t desc) > >> { > >> intptr_t i, opr_sz = simd_oprsz(desc); > >> - uint32_t *d = vd; > >> + int32_t *d = vd, *a = va; > > > > Why the type change ? > > Oh, just because this is logically producing a signed result. Given that we > use -fwrapv, there is no functional change. Seems reasonable, but can you put that in a separate patch if you want to do it, please? thanks -- PMM