[Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

[Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

[Alexander Graf]

We now have to pass an address space to our _phys helpers. During the
transition apparently the EPR exit path missed out, so let's put it there.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 target-ppc/kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 015ca82..84aa4e4 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1232,7 +1232,7 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_run *run)
 #endif
     case KVM_EXIT_EPR:
         DPRINTF("handle epr\n");
-        run->epr.epr = ldl_phys(env->mpic_iack);
+        run->epr.epr = ldl_phys(cs->as, env->mpic_iack);
         ret = 0;
         break;
     case KVM_EXIT_WATCHDOG:
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

[Peter Maydell]

On 14 February 2014 08:15, Alexander Graf <agraf@suse.de> wrote:
> We now have to pass an address space to our _phys helpers. During the
> transition apparently the EPR exit path missed out, so let's put it there.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

I assume this is a compile failure -- do you want it applied
directly or are you happy to just let it go through the ppc queue?

thanks
-- PMM

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

[Alexander Graf]

On 14.02.2014, at 09:53, Peter Maydell <peter.maydell@linaro.org> wrote:

> On 14 February 2014 08:15, Alexander Graf <agraf@suse.de> wrote:
>> We now have to pass an address space to our _phys helpers. During the
>> transition apparently the EPR exit path missed out, so let's put it there.
>> 
>> Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> I assume this is a compile failure -- do you want it applied
> directly or are you happy to just let it go through the ppc queue?

It'd be awesome if you could pick it up directly. Compile breakages always make bisecting hard.


Alex

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

[Peter Maydell]

On 14 February 2014 09:13, Alexander Graf <agraf@suse.de> wrote:
>
> On 14.02.2014, at 09:53, Peter Maydell <peter.maydell@linaro.org> wrote:
>
>> On 14 February 2014 08:15, Alexander Graf <agraf@suse.de> wrote:
>>> We now have to pass an address space to our _phys helpers. During the
>>> transition apparently the EPR exit path missed out, so let's put it there.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>> I assume this is a compile failure -- do you want it applied
>> directly or are you happy to just let it go through the ppc queue?
>
> It'd be awesome if you could pick it up directly. Compile breakages always make bisecting hard.

Applied, thanks.

-- PMM