From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbQLF-0007Jx-I5 for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:46:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbQLC-0004Yw-AA for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:46:29 -0400 Received: from mail-vk0-f52.google.com ([209.85.213.52]:34247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbQLC-0004Xv-6h for qemu-devel@nongnu.org; Mon, 14 Sep 2015 05:46:26 -0400 Received: by vkhf67 with SMTP id f67so55709928vkh.1 for ; Mon, 14 Sep 2015 02:46:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1442000463-22777-1-git-send-email-kwolf@redhat.com> References: <1442000463-22777-1-git-send-email-kwolf@redhat.com> From: Peter Maydell Date: Mon, 14 Sep 2015 10:46:06 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/23] Block layer patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: QEMU Developers , Qemu-block On 11 September 2015 at 20:40, Kevin Wolf wrote: > The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c980b= 7c: > > scripts/qemu-gdb: Add brief comment describing usage (2015-09-11 17:14:= 50 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 1fcbcc93872953d08cd35830d1169fed19196290: > > qcow2: Make qcow2_alloc_bytes() more explicit (2015-09-11 20:03:02 +020= 0) > > ---------------------------------------------------------------- > Block layer patches > > ---------------------------------------------------------------- Hi. I'm afraid this fails to build on 32-bit: /home/pm215/qemu/block/qcow2-refcount.c: In function =E2=80=98realloc_refco= unt_array=E2=80=99: /home/pm215/qemu/block/qcow2-refcount.c:1294:16: error: cast to pointer from integer of different size [-Werror=3Dint-to-pointer-cast] memset((void *)((uintptr_t)new_ptr + old_byte_size), 0, ^ cc1: all warnings being treated as errors /home/pm215/qemu/rules.mak:57: recipe for target 'block/qcow2-refcount.o' f= ailed make: *** [block/qcow2-refcount.o] Error 1 (old_byte_size is int64_t, so (uintptr_t)new_ptr + old_byte_size becomes a 64-bit addition, and then you cast it to a 32-bit pointer.) thanks -- PMM