From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQhfZ-00015q-PW for qemu-devel@nongnu.org; Mon, 09 Jan 2017 16:39:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQhfZ-000219-4c for qemu-devel@nongnu.org; Mon, 09 Jan 2017 16:39:57 -0500 Received: from mail-vk0-x22a.google.com ([2607:f8b0:400c:c05::22a]:33008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQhfZ-000215-0U for qemu-devel@nongnu.org; Mon, 09 Jan 2017 16:39:57 -0500 Received: by mail-vk0-x22a.google.com with SMTP id 137so348810086vkl.0 for ; Mon, 09 Jan 2017 13:39:56 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170109201340.16593-4-dgilbert@redhat.com> References: <20170109201340.16593-1-dgilbert@redhat.com> <20170109201340.16593-4-dgilbert@redhat.com> From: Peter Maydell Date: Mon, 9 Jan 2017 21:39:36 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 3/3] vmstate registration: check return values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: QEMU Developers , "Michael S. Tsirkin" , Paolo Bonzini , Juan Quintela , Amit Shah On 9 January 2017 at 20:13, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check qdev's call to vmstate_register_with_alias_id; that gets > most of the common uses; there's hundreds of calls via vmstate_register > which could get fixed over time. Not quite that bad, I think -- I make it just over 50 calls. thanks -- PMM