From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59190)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zr6fw-0002N9-F5
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 12:00:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zr6fv-0008Jc-Bj
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 12:00:40 -0400
Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]:33466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Zr6fv-0008JT-7c
	for qemu-devel@nongnu.org; Tue, 27 Oct 2015 12:00:39 -0400
Received: by vkgy127 with SMTP id y127so124105658vkg.0
	for <qemu-devel@nongnu.org>; Tue, 27 Oct 2015 09:00:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA83TebHEwiOrj-=tDVLQy2wake4U964CHy7jGEBJtw3wQ@mail.gmail.com>
References: <1445956409-1818-1-git-send-email-peter.maydell@linaro.org>
	<CAFEAcA83TebHEwiOrj-=tDVLQy2wake4U964CHy7jGEBJtw3wQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 27 Oct 2015 16:00:18 +0000
Message-ID: <CAFEAcA_5HP4HEDzEeNpA=Jm+-cTG9uzXr-zvYi0rnHwP+5S+gw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PULL 00/27] target-arm queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>

On 27 October 2015 at 15:57, Peter Maydell <peter.maydell@linaro.org> wrote:
> I will squash in the fix:
>
> diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c
> index 45cf00d..261608d 100644
> --- a/hw/char/imx_serial.c
> +++ b/hw/char/imx_serial.c
> @@ -318,8 +318,7 @@ static void imx_serial_realize(DeviceState *dev,
> Error **errp)
>          qemu_chr_add_handlers(s->chr, imx_can_receive, imx_receive,
>                                imx_event, s);
>      } else {
> -        DPRINTF("No char dev for uart at 0x%" HWADDR_PRIx "\n",
> -                s->iomem.ram_addr);
> +        DPRINTF("No char dev for uart"\n");
>      }
>  }

...without the stray extra '"', obviously :-)

-- PMM