From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50143)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bog9x-0003jv-FL
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 20:22:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bog9v-0002RQ-6w
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 20:22:08 -0400
Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:35900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bog9v-0002RK-2C
	for qemu-devel@nongnu.org; Mon, 26 Sep 2016 20:22:07 -0400
Received: by mail-ua0-x236.google.com with SMTP id n13so4906227uaa.3
	for <qemu-devel@nongnu.org>; Mon, 26 Sep 2016 17:22:06 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAAqcGHnCx2m--_t-ppO_ao5P-V7vvB16YyA8Ar=j7Uqi0Bi_+A@mail.gmail.com>
References: <1474919934-21518-1-git-send-email-riku.voipio@linaro.org>
	<CAFEAcA-iY8qP3JSn7xbaiszitUWk2JOu4Q+nnACPT6qY-NM2Dg@mail.gmail.com>
	<CAAqcGHnCx2m--_t-ppO_ao5P-V7vvB16YyA8Ar=j7Uqi0Bi_+A@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 26 Sep 2016 17:21:45 -0700
Message-ID: <CAFEAcA_63Nm9BQGKQ7u_jEgboOQXgo_3ivTdE6c+0zD1B=YmYw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test
 for linux-user
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 26 September 2016 at 16:36, Riku Voipio <riku.voipio@linaro.org> wrote:
> On 27 September 2016 at 00:08, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Do you have some examples of the false positives you want
>> to suppress here? For new code I would hope that we can
>> handle host-arch-specifics by having new files (or just
>> new #defines etc) in linux-user/host/$ARCH/ rather than
>> inline #ifdeffery in the main files.
>
> One example from your patch:
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg05650.html
>
> And another from Laurent:
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg06486.html
>
> Every new syscall will comes with "#ifdef TARGET_NR_foo and
> defined(__NR_foo)", while host/target combos catch up. Now, most
> TARGET_NR_foo's are needed only for unicore32, but the __NR_foo
> defines will be needed for a very long time.

Oh, I see; I don't think of the __NR_foo as being "architecture
specific". I think we'd be better off specifically whitelisting
those in checkpatch rather than turning off the whole check
for linux-user.

thanks
-- PMM