All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Helge Deller <deller@gmx.de>
Cc: Sven Schnelle <svens@stackframe.org>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC
Date: Mon, 2 Mar 2020 19:31:42 +0000	[thread overview]
Message-ID: <CAFEAcA_80Hm-FX0-OWW3yJ2H1d=mqxt8tKsvP7LpDayQBXRtGw@mail.gmail.com> (raw)
In-Reply-To: <e0e3cf61-33ef-3b95-4a2b-2458cdcab296@gmx.de>

On Mon, 2 Mar 2020 at 19:23, Helge Deller <deller@gmx.de> wrote:
>
> On 17.02.20 18:56, Peter Maydell wrote:
> > On Fri, 24 Jan 2020 at 23:20, Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >>
> >> From: Helge Deller <deller@gmx.de>
> >>
> >> LASI is a built-in multi-I/O chip which supports serial, parallel,
> >> network (Intel i82596 Apricot), sound and other functionalities.
> >> LASI has been used in many HP PARISC machines.
> >> This patch adds the necessary parts to allow Linux and HP-UX to detect
> >> LASI and the network card.

> > So we could be reading off the end of the buffer.
> >
> > I don't know whether the buffer should be 4 bytes
> > larger to allow for the checksum, or if the len calculation
> > is wrong.
>
> I'm working on a bigger patch which will improve this driver.
> It still has some issues with the emulation in Linux and HP-UX.
> With the patch I will take try to fix those out-of-bounds
> accesses too.
> It will take some time though, until I will send the patch.

As this is a bug fix and in particular a fix for a buffer
overrun, I think it would be better if you could send a
patch that just fixes this. If you include it in a larger
general-improvements patch we'll probably just ask you to
split it out when we get to code-review of that patchset,
and doing it that way will mean we have the buggy code
in QEMU for longer.

thanks
-- PMM


  reply	other threads:[~2020-03-02 19:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 23:19 [PULL v3 00/11] target/hppa patch queue Richard Henderson
2020-01-24 23:19 ` [PULL v3 01/11] hw/hppa/dino.c: Improve emulation of Dino PCI chip Richard Henderson
2020-01-24 23:20 ` [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC Richard Henderson
2020-02-17 17:56   ` Peter Maydell
2020-03-02 19:23     ` Helge Deller
2020-03-02 19:31       ` Peter Maydell [this message]
2020-03-02 20:34         ` Helge Deller
2020-03-02 23:25           ` Philippe Mathieu-Daudé
2020-03-05 13:05   ` Philippe Mathieu-Daudé
2020-01-24 23:20 ` [PULL v3 03/11] ps2: accept 'Set Key Make and Break' commands Richard Henderson
2020-01-24 23:20 ` [PULL v3 04/11] hppa: add emulation of LASI PS2 controllers Richard Henderson
2020-02-18  8:29   ` Philippe Mathieu-Daudé
2020-01-24 23:20 ` [PULL v3 05/11] hppa: Switch to tulip NIC by default Richard Henderson
2020-01-24 23:20 ` [PULL v3 06/11] seabios-hppa: update to latest version Richard Henderson
2020-01-24 23:20 ` [PULL v3 07/11] hppa: Add emulation of Artist graphics Richard Henderson
2020-01-24 23:20 ` [PULL v3 08/11] hw/hppa/machine: Correctly check the firmware is in PDC range Richard Henderson
2020-01-24 23:20 ` [PULL v3 09/11] hw/hppa/machine: Restrict the total memory size to 3GB Richard Henderson
2020-01-24 23:20 ` [PULL v3 10/11] hw/hppa/machine: Map the PDC memory region with higher priority Richard Henderson
2020-01-24 23:20 ` [PULL v3 11/11] target/hppa: Allow, but diagnose, LDCW aligned only mod 4 Richard Henderson
2020-01-27 11:23 ` [PULL v3 00/11] target/hppa patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_80Hm-FX0-OWW3yJ2H1d=mqxt8tKsvP7LpDayQBXRtGw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.