From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMc3j-00027E-Fr for qemu-devel@nongnu.org; Tue, 04 Aug 2015 09:15:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMc3f-0007yF-0H for qemu-devel@nongnu.org; Tue, 04 Aug 2015 09:15:11 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:32771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMc3e-0007xK-Rw for qemu-devel@nongnu.org; Tue, 04 Aug 2015 09:15:06 -0400 Received: by vkgc186 with SMTP id c186so3324167vkg.0 for ; Tue, 04 Aug 2015 06:15:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150804124658.GC6574@aurel32.net> References: <1438593291-27109-1-git-send-email-alex.bennee@linaro.org> <1438593291-27109-11-git-send-email-alex.bennee@linaro.org> <20150804124658.GC6574@aurel32.net> From: Peter Maydell Date: Tue, 4 Aug 2015 14:14:47 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 10/11] vl.c: log system invocation when enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: QEMU Trivial , QEMU Developers , Peter Crosthwaite , Paolo Bonzini , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Richard Henderson On 4 August 2015 at 13:46, Aurelien Jarno wrote: > On 2015-08-04 13:40, Peter Maydell wrote: >> On 3 August 2015 at 10:14, Alex Benn=C3=A9e wro= te: >> > gcc_flags=3D"-Wold-style-declaration -Wold-style-definition -Wtype-li= mits" >> > -gcc_flags=3D"-Wformat-security -Wformat-y2k -Winit-self -Wignored-qua= lifiers $gcc_flags" >> > +gcc_flags=3D"-Wformat-security -Wno-format-y2k -Winit-self -Wignored-= qualifiers $gcc_flags" >> >> Why do we need this warning switch change? > > Some locales might have the year on 2 digits only, so this triggers a > warning. That's also a reason I suggested to use a fixed date format. Agreed -- we don't want locale-specific log formats. thanks -- PMM