From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WHxho-0005xG-2N
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:44:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WHxhj-000748-V5
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:44:32 -0500
Received: from mail-la0-f42.google.com ([209.85.215.42]:50687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WHxhj-00073t-O0
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 10:44:27 -0500
Received: by mail-la0-f42.google.com with SMTP id ec20so1583442lab.15
	for <qemu-devel@nongnu.org>; Mon, 24 Feb 2014 07:44:26 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <5302B4B0.7050507@suse.de>
References: <1392659611-8439-1-git-send-email-peter.maydell@linaro.org>
	<5302B4B0.7050507@suse.de>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 24 Feb 2014 15:44:06 +0000
Message-ID: <CAFEAcA_=cjyH85hdnSNc9jMiU=Lhdc26BJUkpL0jry8krP8L8Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun
 output_irq array in init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>
Cc: Evgeny Voevodin <e.voevodin@samsung.com>, Patch Tracking <patches@linaro.org>, Igor Mitsyanko <i.mitsyanko@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, qemu-stable <qemu-stable@nongnu.org>, Dmitry Solodkiy <d.solodkiy@samsung.com>, Maksim Kozlov <m.kozlov@samsung.com>

On 18 February 2014 01:17, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 17.02.2014 18:53, schrieb Peter Maydell:
>> The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs;
>> use the correct constant in the loop initializing our output
>> sysbus IRQs so that we don't overrun the output_irq[] array.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>  hw/intc/exynos4210_combiner.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner=
.c
>> index ef5e8eb..3287479 100644
>> --- a/hw/intc/exynos4210_combiner.c
>> +++ b/hw/intc/exynos4210_combiner.c
>> @@ -418,7 +418,7 @@ static int exynos4210_combiner_init(SysBusDevice *sb=
d)
>>      qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ);
>>
>>      /* Connect SysBusDev irqs to device specific irqs */
>> -    for (i =3D 0; i < IIC_NIRQ; i++) {
>> +    for (i =3D 0; i < IIC_NGRP; i++) {
>
> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
>
> It seems that IIC_NIRQ =3D=3D IIC_NGRP * 8, so please don't forget to Cc
> qemu-stable@nongnu.org in the commit message for 1.7.1.

Thanks; applied to target-arm.next and added the cc:stable line.

-- PMM