From: Peter Maydell <peter.maydell@linaro.org>
To: Gan Qixin <ganqixin@huawei.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Euler Robot <euler.robot@huawei.com>,
"Chenqun \(kuhn\)" <kuhn.chenqun@huawei.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 1/2] pl031: Use timer_free() in the finalize function to avoid memleaks
Date: Tue, 12 Jan 2021 16:42:08 +0000 [thread overview]
Message-ID: <CAFEAcA_AG77gJySKNRcKFrGsmhn2uNZMyB4aNynD6w5rFTz=7g@mail.gmail.com> (raw)
In-Reply-To: <20210112112705.380534-2-ganqixin@huawei.com>
On Tue, 12 Jan 2021 at 11:29, Gan Qixin <ganqixin@huawei.com> wrote:
>
> When running device-introspect-test, a memory leak occurred in the pl031_init
> function, this patch use timer_free() in the finalize function to fix it.
>
> ASAN shows memory leak stack:
>
> Direct leak of 48 byte(s) in 1 object(s) allocated from:
> #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0)
> #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800)
> #2 0xaaabf5621cfc in timer_new_full qemu/include/qemu/timer.h:523
> #3 0xaaabf5621cfc in timer_new qemu/include/qemu/timer.h:544
> #4 0xaaabf5621cfc in timer_new_ns qemu/include/qemu/timer.h:562
> #5 0xaaabf5621cfc in pl031_init qemu/hw/rtc/pl031.c:194
> #6 0xaaabf6339f6c in object_initialize_with_type qemu/qom/object.c:515
> #7 0xaaabf633a1e0 in object_new_with_type qemu/qom/object.c:729
> #8 0xaaabf6375e40 in qmp_device_list_properties qemu/qom/qom-qmp-cmds.c:153
> #9 0xaaabf5a95540 in qdev_device_help qemu/softmmu/qdev-monitor.c:283
> #10 0xaaabf5a96940 in qmp_device_add qemu/softmmu/qdev-monitor.c:801
> #11 0xaaabf5a96e70 in hmp_device_add qemu/softmmu/qdev-monitor.c:916
> #12 0xaaabf5ac0a2c in handle_hmp_command qemu/monitor/hmp.c:1100
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2021-01-12 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 11:27 [PATCH v3 0/2] Fix some memleaks caused by timer_new_ns Gan Qixin
2021-01-12 11:27 ` [PATCH v3 1/2] pl031: Use timer_free() in the finalize function to avoid memleaks Gan Qixin
2021-01-12 16:42 ` Peter Maydell [this message]
2021-01-12 19:59 ` Laurent Vivier
2021-01-12 11:27 ` [PATCH v3 2/2] misc/mos6522: Use timer_free() in the finalize function to avoid memleak Gan Qixin
2021-01-12 12:17 ` Philippe Mathieu-Daudé
2021-01-12 16:42 ` Peter Maydell
2021-01-12 20:00 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_AG77gJySKNRcKFrGsmhn2uNZMyB4aNynD6w5rFTz=7g@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=euler.robot@huawei.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.