Re: [Qemu-devel] [PATCH 10/12] linux-user: clock_nanosleep errno Handling on PPC

From: Peter Maydell <peter.maydell@linaro.org>
To: Tom Musta <tommusta@gmail.com>
Cc: Riku Voipio <riku.voipio@linaro.org>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 10/12] linux-user: clock_nanosleep errno Handling on PPC
Date: Mon, 4 Aug 2014 18:43:31 +0100	[thread overview]
Message-ID: <CAFEAcA_ApfXsNV8OUCtWz1E9TxeXBB69egjwFOqu12a3qVTtYw@mail.gmail.com> (raw)
In-Reply-To: <1407170739-12237-11-git-send-email-tommusta@gmail.com>

On 4 August 2014 17:45, Tom Musta <tommusta@gmail.com> wrote:
> The clock_nanosleep syscall is unusual in that it returns positive
> numbers in error handling situations, versus returning -1 and setting
> errno, or returning a negative errno value.  On POWER, the kernel will
> set the SO bit of CR0 to indicate failure in a syscall.  QEMU has
> generic handling to do this for syscalls with standard return values.
>
> Add special case code for clock_nanosleep to handle CR0 properly.
>
> Signed-off-by: Tom Musta <tommusta@gmail.com>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 95cee0b..5660520 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8993,6 +8993,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>          ret = get_errno(clock_nanosleep(arg1, arg2, &ts, arg4 ? &ts : NULL));
>          if (arg4)
>              host_to_target_timespec(arg4, &ts);
> +
> +#if defined(TARGET_PPC) || defined(TARGET_PPC64)

...isn't TARGET_PPC always defined if TARGET_PPC64 is?
(ie second condition in the || is unnecessary)

-- PMM