All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has")
Date: Thu, 29 Sep 2016 17:29:34 -0700	[thread overview]
Message-ID: <CAFEAcA_CkrTSB_Ru0k_5etp85BCPomSbq93JK22R5aPqfGjEvA@mail.gmail.com> (raw)
In-Reply-To: <20160930000428.22382-1-j.neuschaefer@gmx.net>

On 29 September 2016 at 17:04, Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> ---
> v2:
> - Preserve the poetic sound of "Many a flamewar", which Peter Maydell
>   pointed out.
> ---
>  CODING_STYLE | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index e7fde15..f53180b 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -9,7 +9,7 @@ patches before submitting.
>  Of course, the most important aspect in any coding style is whitespace.
>  Crusty old coders who have trouble spotting the glasses on their noses
>  can tell the difference between a tab and eight spaces from a distance
> -of approximately fifteen parsecs.  Many a flamewar have been fought and
> +of approximately fifteen parsecs.  Many a flamewar has been fought and
>  lost on this issue.
>
>  QEMU indents are four spaces.  Tabs are never used, except in Makefiles

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

  reply	other threads:[~2016-09-30  0:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 20:46 [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar") Jonathan Neuschäfer
2016-09-29 22:14 ` Peter Maydell
2016-09-29 23:38   ` Jonathan Neuschäfer
2016-09-30  0:04     ` [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has") Jonathan Neuschäfer
2016-09-30  0:29       ` Peter Maydell [this message]
2016-10-08  8:12       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_CkrTSB_Ru0k_5etp85BCPomSbq93JK22R5aPqfGjEvA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.