All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-arm <qemu-arm@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 0/5] Fix crashes with introspection
Date: Thu, 12 Jul 2018 16:48:24 +0100	[thread overview]
Message-ID: <CAFEAcA_PehgESP845QOiVOO2Ov1wd2r0MLLtN17wsRVwB-wgHQ@mail.gmail.com> (raw)
In-Reply-To: <1531409463-3843-1-git-send-email-thuth@redhat.com>

On 12 July 2018 at 16:30, Thomas Huth <thuth@redhat.com> wrote:
> As discovered recently, you can crash QEMU with a lot of devices
> that do not get the reference counting of child objects right.
> You just have to run 'device-list-properties' and call 'info qtree'
> afterwards.
> This patch series fixes a bunch of these problems in the ARM code.
> I did not fix all problems yet, since it is quite time consuming
> and I first want to get some feedback whether this is the right
> way to go or not.
>
> Thomas Huth (5):
>   qom/object: Add a new function object_initialize_as_child()
>   hw/core/sysbus: Add a function for creating and attaching an object
>   hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported
>     machines
>   hw/arm/armv7: Fix crash when introspecting the "iotkit" device
>   hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv
>     device

Seems good to me. I'm cc'ing Igor since he had some opinions when
I sent a previous (and rather more ad-hoc) attempt at reducing
the boilerplate around creating and parenting sysbus objects:
http://lists.gnu.org/archive/html/qemu-devel/2018-02/msg04493.html

thanks
-- PMM

      parent reply	other threads:[~2018-07-12 15:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 15:30 [Qemu-devel] [PATCH v1 0/5] Fix crashes with introspection Thomas Huth
2018-07-12 15:30 ` [Qemu-devel] [PATCH 1/5] qom/object: Add a new function object_initialize_as_child() Thomas Huth
2018-07-12 16:52   ` Eduardo Habkost
2018-07-12 16:55     ` Thomas Huth
2018-07-12 17:02       ` Eduardo Habkost
2018-07-12 17:09       ` Peter Maydell
2018-07-13  6:27         ` Paolo Bonzini
2018-07-13  6:26       ` Paolo Bonzini
2018-07-13  7:57         ` Thomas Huth
2018-07-13 10:12           ` Paolo Bonzini
2018-07-13 11:20             ` Thomas Huth
2018-07-12 17:15   ` Eduardo Habkost
2018-07-12 15:31 ` [Qemu-devel] [PATCH 2/5] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] [PATCH 3/5] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] [PATCH 4/5] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-12 15:31 ` [Qemu-devel] [PATCH 5/5] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-12 15:40 ` [Qemu-devel] [PATCH v1 0/5] Fix crashes with introspection Paolo Bonzini
2018-07-12 15:48 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_PehgESP845QOiVOO2Ov1wd2r0MLLtN17wsRVwB-wgHQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.