All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH for-7.0] rtc: Move RTC function prototypes to their own header
Date: Thu, 27 Jan 2022 16:34:56 +0000	[thread overview]
Message-ID: <CAFEAcA_SjALXf813F6f1uuh5td4FQdBMaP1m90vu00hS1VmjbA@mail.gmail.com> (raw)
In-Reply-To: <20211129205505.1235070-1-peter.maydell@linaro.org>

On Mon, 29 Nov 2021 at 20:55, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> softmmu/rtc.c defines two public functions: qemu_get_timedate() and
> qemu_timedate_diff().  Currently we keep the prototypes for these in
> qemu-common.h, but most files don't need them.  Move them to their
> own header, a new include/sysemu/rtc.h.
>
> Since the C files using these two functions did not need to include
> qemu-common.h for any other reason, we can remove those include lines
> when we add the include of the new rtc.h.
>
> The license for the .h file follows that of the softmmu/rtc.c
> where both the functions are defined.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I have added documentation comments for the two functions, but
> since my understanding of them and their purpose is little shaky
> review would be welcome.

I forgot about this patch from November; since Philippe has reviewed
it I'll take it via target-arm.next.

thanks
-- PMM


      parent reply	other threads:[~2022-01-27 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 20:55 [PATCH for-7.0] rtc: Move RTC function prototypes to their own header Peter Maydell
2021-12-01 12:58 ` Philippe Mathieu-Daudé
2022-01-27 16:34 ` Peter Maydell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_SjALXf813F6f1uuh5td4FQdBMaP1m90vu00hS1VmjbA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.