From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5753C64E8A for ; Thu, 3 Dec 2020 11:40:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4712D208FE for ; Thu, 3 Dec 2020 11:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4712D208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkmyd-0005yk-82 for qemu-devel@archiver.kernel.org; Thu, 03 Dec 2020 06:40:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkmx6-0004Xs-Cu for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:39:14 -0500 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:39653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkmx1-0000CE-R4 for qemu-devel@nongnu.org; Thu, 03 Dec 2020 06:39:12 -0500 Received: by mail-ed1-x542.google.com with SMTP id c7so1737751edv.6 for ; Thu, 03 Dec 2020 03:39:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RbKXYjd8/Y5arVN6NTbqlnensKVNUl92Ie8cb497S/E=; b=tDfhgsQve4TXQdjZKrSUJF3MVQirO/Y2EfisW/MZnaXIFL5wFFnn8st1sPOuvIbo3m CF9dhz0Vs2S1IQvAWsofMRNdI6buyCke+usY0UXOXBsp+k7LPp/5l4FERHlHzCDUi1jx Xlnsu8Xf0bUPOlC6oShmsEuJFc6aJ5/6MaJJKbDEP63DfCiYqe2hKza+iWkzmKyUJIP1 SkjOQgUJxWfzm4XPaVH3FZ7j2e1QDnpOsLjMC9/QpSS6L9eSgP8AF7i1Zn0xuERxKPPb ejxzDbbXVl/+twwbwOFU89wSlMDA6f0/1HJtUUg+blQkateLpkumShbBrdaUx4XZMjPi Kjfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RbKXYjd8/Y5arVN6NTbqlnensKVNUl92Ie8cb497S/E=; b=bl2plWaGQeCdR0ouO40VMtW1gplPILYDX8lctkiH8M/VW6jEVSX9zppobgDxzz6a6E a1HPJdQRMYiXuM1YVs5MWh2sgZkG/VzxYWN4pR7/XqZ6rIVpuBtbBSKAK1XiIwlQwfif RNv3DWMXqgtN0sIuXcxsou8fyW/hSQykEnc0Kwggyzz1v/nlw9YwbcvgJ8OTlftxZPar PXleJ4jN67E3msJMA49j+86vWu8xac+7qpQZ8jSHvZ1rPaU0D3llscionj8/9KHxOICe DYhxeJ8hahn4nYXrPD+BvXHlHrsVwfhMHSpWZxhGydkVhp1ijjve/3swul4/KjfPTEh2 I8xw== X-Gm-Message-State: AOAM532ng6a/R1U4WmWEx4f5qwlGw6xwBfNeuOLigc6QoKkX2pLAJJgm JXmsWXJ1obpXGg94koPfio6CG4YZGLfxfbiz67EnVw== X-Google-Smtp-Source: ABdhPJzyuWhdd8geSoaHjF9gGLM6LAwiMYNrujxFKG/T5HPH2CuJ3EKmYp22890CUg88jATCQpCXb3puDYd0Z6KxI+Q= X-Received: by 2002:a50:fd18:: with SMTP id i24mr2511115eds.146.1606995546039; Thu, 03 Dec 2020 03:39:06 -0800 (PST) MIME-Version: 1.0 References: <20201125040642.2339476-1-richard.henderson@linaro.org> <20201125040642.2339476-6-richard.henderson@linaro.org> In-Reply-To: <20201125040642.2339476-6-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 3 Dec 2020 11:38:54 +0000 Message-ID: Subject: Re: [PATCH 05/11] target/arm: Enforce alignment for SRS To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x542.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 25 Nov 2020 at 04:09, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/translate.c > index 4406f6a67c..b1f43bfb8f 100644 > --- a/target/arm/translate.c > +++ b/target/arm/translate.c > @@ -5124,11 +5124,13 @@ static void gen_srs(DisasContext *s, > } > tcg_gen_addi_i32(addr, addr, offset); > tmp = load_reg(s, 14); > - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); > + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), > + MO_UL | MO_ALIGN | s->be_data); > tcg_temp_free_i32(tmp); > tmp = load_cpu_field(spsr); > tcg_gen_addi_i32(addr, addr, 4); > - gen_aa32_st32(s, tmp, addr, get_mem_index(s)); > + gen_aa32_st_i32(s, tmp, addr, get_mem_index(s), > + MO_UL | MO_ALIGN | s->be_data); Having just come back to look at this as a result of reading a review comment from you on the v8.1M series, it's a bit unfortunate that we now have to remember to factor in s->be_data in every memory access. Previously gen_aa32_st32() got this right for us automatically, as well as being able to provide the right sized MO_UL or whatever part... Can we make the new API a bit less awkward ? (I suspect we're eventually going to want to be able to pass an enum for "always OK unaligned", "never OK unaligned", or "OK unaligned only if SCTLR.A is 0", for that matter.) thanks -- PMM