From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1gP8Fd-0003nM-7L
	for qemu-devel@nongnu.org; Tue, 20 Nov 2018 10:47:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1gP8FZ-0005CS-14
	for qemu-devel@nongnu.org; Tue, 20 Nov 2018 10:47:43 -0500
Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:42119)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <peter.maydell@linaro.org>)
	id 1gP8FW-0005As-4q
	for qemu-devel@nongnu.org; Tue, 20 Nov 2018 10:47:39 -0500
Received: by mail-ot1-x342.google.com with SMTP id n46so2043916otb.9
	for <qemu-devel@nongnu.org>; Tue, 20 Nov 2018 07:47:37 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <c0c4051d-fe57-7399-9904-65425c6efc26@acm.org>
References: <20181115192446.17187-1-minyard@acm.org>
	<20181115192446.17187-2-minyard@acm.org>
	<8add8514-f353-b914-78e8-e9f3e9be840d@redhat.com>
	<c0c4051d-fe57-7399-9904-65425c6efc26@acm.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 20 Nov 2018 15:47:16 +0000
Message-ID: <CAFEAcA_Ubfuf-w66JJcPT+nWFFw-aa+Wfdm1ocGHf+VCSM_-qQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 01/12] i2c: Split smbus into parts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Minyard <minyard@acm.org>
Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, "Dr . David Alan Gilbert" <dgilbert@redhat.com>, Corey Minyard <cminyard@mvista.com>

On 16 November 2018 at 13:20, Corey Minyard <minyard@acm.org> wrote:
> On 11/15/18 4:22 PM, Philippe Mathieu-Daud=C3=A9 wrote:
>>> --- /dev/null
>>> +++ b/include/hw/i2c/smbus_eeprom.h
>>> @@ -0,0 +1,11 @@
>>
>>
>> You missed the copyright notice here.
>
>
> Other files don't have copyright notices (i2c.h, for instance), and for
> the smbus.[ch] case the copyrights are kind of mixed up, the include
> files had the big header with a copyright by one company and the C
> file had a different copyright notice by a different company.
>
> Not a huge deal, but I didn't include it in that file because I didn't
> think it was necessary.  I'm wondering if it would be best to
> establish a style like Linux has, with the // SPDX... thing on the
> first line.

Yeah, we have some legacy files with no copyright notice, but we
usually try to avoid that for new files. New files should have
a copyright notice and a license statement. (If you copied from
a file without a license statement, LICENSE says that means
2-or-later.)

We don't yet use SPDX headers. (They're just a different and
shorter way to write the license statement.)

thanks
-- PMM