All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Stefan Weil <sw@weilnetz.de>,
	QEMU Developer <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU
Date: Tue, 15 May 2018 15:51:42 +0100	[thread overview]
Message-ID: <CAFEAcA_WPidxh81a9vgCTm2fe3G_zKybNTfA0PFGYn=UKFfxGg@mail.gmail.com> (raw)
In-Reply-To: <291b8b6f-1692-a5ee-f44c-4f8c4dd614fa@twiddle.net>

On 15 May 2018 at 15:46, Richard Henderson <rth@twiddle.net> wrote:
> On 05/15/2018 06:25 AM, Peter Maydell wrote:
>> I guess that having the compiler check is better than finding them
>> later with coverity. It's a shame gcc doesn't support the standard
>> mechanism of using /* fallthrough */ to mark these, though.
>
> It does.  Apparently not by default anymore, however:
>
> @item @option{-Wimplicit-fallthrough=0} disables the warning altogether.
>
> @item @option{-Wimplicit-fallthrough=1} matches @code{.*} regular
> expression, any comment is used as fallthrough comment.
>
> @item @option{-Wimplicit-fallthrough=2} case insensitively matches
> @code{.*falls?[ \t-]*thr(ough|u).*} regular expression.
>
> @item @option{-Wimplicit-fallthrough=3} case sensitively matches one of the
> following regular expressions:
> ...
>
> I think either =2 or =1 would work for us in QEMU.

1 sounds too broad, we don't want any old comment to count.
2 is probably what we want.

thanks
-- PMM

  reply	other threads:[~2018-05-15 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13  9:06 [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU Stefan Weil
2018-05-13  9:57 ` Stefan Weil
2018-05-13 14:44   ` Peter Maydell
2018-05-15 12:13   ` Peter Maydell
2018-05-15 13:13     ` Stefan Weil
2018-05-15 13:25       ` Peter Maydell
2018-05-15 14:46         ` Richard Henderson
2018-05-15 14:51           ` Peter Maydell [this message]
2018-05-18 10:34           ` Peter Maydell
2018-05-18 15:57             ` Richard Henderson
2018-05-17 16:15       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_WPidxh81a9vgCTm2fe3G_zKybNTfA0PFGYn=UKFfxGg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.