From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/7] Convert (ffs(val) - 1) to ctz32(val)
Date: Tue, 17 Mar 2015 12:09:22 +0000 [thread overview]
Message-ID: <CAFEAcA_WRN7U2ryRnyT6XVp8a9VtbHNVD6XXX3b8QaTkSo0++w@mail.gmail.com> (raw)
In-Reply-To: <1426593410-21405-3-git-send-email-stefanha@redhat.com>
On 17 March 2015 at 11:56, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> This commit was generated mechanically by coccinelle from the following
> semantic patch:
>
> @@
> expression val;
> @@
> - (ffs(val) - 1)
> + ctz32(val)
Did you check all these callsites to make sure that the value
passed in can never be zero? (ffs(0) - 1) is -1 whereas
ctz32(0) is 32...
-- PMM
next prev parent reply other threads:[~2015-03-17 12:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 11:56 [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32() Stefan Hajnoczi
2015-03-17 11:56 ` [Qemu-devel] [PATCH 1/7] bt-sdp: fix broken uuids power-of-2 calculation Stefan Hajnoczi
2015-03-17 14:37 ` Eric Blake
2015-03-17 11:56 ` [Qemu-devel] [PATCH 2/7] Convert (ffs(val) - 1) to ctz32(val) Stefan Hajnoczi
2015-03-17 12:09 ` Peter Maydell [this message]
2015-03-17 14:54 ` Stefan Hajnoczi
2015-03-17 11:56 ` [Qemu-devel] [PATCH 3/7] Convert ffs() != 0 callers to ctz32() Stefan Hajnoczi
2015-03-30 15:42 ` Richard Henderson
2015-03-17 11:56 ` [Qemu-devel] [PATCH 4/7] sd: convert sd_normal_command() ffs(3) call " Stefan Hajnoczi
2015-03-17 11:56 ` [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update() Stefan Hajnoczi
2015-03-17 14:58 ` Paolo Bonzini
2015-03-30 15:44 ` Richard Henderson
2015-03-17 11:56 ` [Qemu-devel] [PATCH 6/7] os-win32: drop ffs(3) prototype Stefan Hajnoczi
2015-03-17 11:56 ` [Qemu-devel] [PATCH 7/7] checkpatch: complain about ffs(3) calls Stefan Hajnoczi
2015-03-17 12:02 ` [Qemu-devel] [PATCH 0/7] Convert ffs(3) to ctz32() Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_WRN7U2ryRnyT6XVp8a9VtbHNVD6XXX3b8QaTkSo0++w@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.