From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VS9Vp-0008Kz-EI
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:50:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VS9Vk-0001YS-78
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:50:01 -0400
Received: from mail-la0-f54.google.com ([209.85.215.54]:65185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VS9Vk-0001Y6-02
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:49:56 -0400
Received: by mail-la0-f54.google.com with SMTP id ea20so3500397lab.41
	for <qemu-devel@nongnu.org>; Fri, 04 Oct 2013 10:49:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1380905823-3981-4-git-send-email-chouteau@adacore.com>
References: <1380905823-3981-1-git-send-email-chouteau@adacore.com>
	<1380905823-3981-4-git-send-email-chouteau@adacore.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Sat, 5 Oct 2013 02:49:33 +0900
Message-ID: <CAFEAcA_WwFU8YsPiYm4j68Ue9JBvLoJ_M-MunbfRxjuppB7H_A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Luiz Capitulino <lcapitulino@redhat.com>

On 5 October 2013 01:57, Fabien Chouteau <chouteau@adacore.com> wrote:

> --- a/target-i386/cpu-qom.h
> +++ b/target-i386/cpu-qom.h
> @@ -23,6 +23,7 @@
>  #include "qom/cpu.h"
>  #include "cpu.h"
>  #include "qapi/error.h"
> +#include "monitor/monitor_def.h"
>  #ifdef TARGET_X86_64
>  #define TYPE_X86_CPU "x86_64-cpu"
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index b682802..616b7da 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -22,6 +22,7 @@
>  #include <inttypes.h>
>
>  #include "cpu.h"
> +#include "cpu-qom.h"
>  #include "sysemu/kvm.h"
>  #include "sysemu/cpus.h"
>  #include "topology.h"
> @@ -47,7 +48,9 @@
>  #include "hw/xen/xen.h"
>  #include "hw/i386/apic_internal.h"
>  #endif
> +#include "monitor/monitor_def.h"
>
> +extern const MonitorDef i386_monitor_defs[];

Declare this in cpu-qom.h, rather than having an
extern declaration in a .c file.


> --- a/target-sparc/cpu-qom.h
> +++ b/target-sparc/cpu-qom.h
> @@ -21,7 +21,6 @@
>  #define QEMU_SPARC_CPU_QOM_H
>
>  #include "qom/cpu.h"
> -#include "cpu.h"

...why have you deleted this #include ?

>
>  #ifdef TARGET_SPARC64
>  #define TYPE_SPARC_CPU "sparc64-cpu"

thanks
-- PMM