From: Peter Maydell <peter.maydell@linaro.org>
To: Brian Norris <briannorris@chromium.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Joe Slater" <joe.slater@windriver.com>,
"MacLeod, Randy" <randy.macleod@windriver.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/1] os_find_datadir: search as in version 4.2
Date: Sat, 8 Aug 2020 16:34:12 +0100 [thread overview]
Message-ID: <CAFEAcA__4GwKKe9rY4ut41f-S-u_AnSkdwHvSX0YoaPwjO3ARw@mail.gmail.com> (raw)
In-Reply-To: <20200808013531.GA166030@google.com>
On Sat, 8 Aug 2020 at 02:35, Brian Norris <briannorris@chromium.org> wrote:
>
> Hello!
>
> On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> > >
> > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell <peter.maydell@linaro.org> wrote:
> > > >
> > > > On Tue, 16 Jun 2020 at 00:00, Joe Slater <joe.slater@windriver.com> wrote:
> > > > >
> > > > > Always look for ../share/qemu then ../pc-bios when looking for datadir.
> > > >
> > > > Could you provide some more context, please? Why is this
> > > > change useful; presumably we broke some setup in 5.0, but
> > > > what exactly ?
> > > >
> > > > I'm guessing this might be a regression introduced by commit
> > > > 6dd2dacedd83d12328 so I'm ccing the relevant people.
> > >
> > > Marco, Paolo: ping? Another user has just asked me the status
> > > of this as they also ran into this regression in what directories
> > > we search...
> >
> > Thanks for the heads-up, I didn't see that bug/mail. Indeed, that
> > commit assumed that either we run from a build directory or from an
> > installed qemu. It seems this is hybrid approach, which I didn't know
> > we supported. I'll check it.
>
> Add one more to the pile! Chrome OS noticed this when upgrading to
> 5.0.0:
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1114204#c8
>
> I'd love to see this applied to a release.
It's just missed 5.1, unfortunately :-(
Marc-André, did you want to review it ?
thanks
-- PMM
next prev parent reply other threads:[~2020-08-08 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 22:58 [PATCH 1/1] os_find_datadir: search as in version 4.2 Joe Slater
2020-06-16 9:19 ` Peter Maydell
2020-06-16 15:37 ` Slater, Joseph
2020-07-15 19:37 ` Peter Maydell
2020-07-15 19:57 ` Marc-André Lureau
2020-08-08 1:35 ` Brian Norris
2020-08-08 15:34 ` Peter Maydell [this message]
2020-08-10 7:29 ` Marc-André Lureau
2020-08-10 21:41 ` Brian Norris
2021-01-23 2:05 ` Brian Norris
2021-01-23 18:08 ` Paolo Bonzini
2020-07-16 14:12 ` Marc-André Lureau
2020-08-10 7:33 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA__4GwKKe9rY4ut41f-S-u_AnSkdwHvSX0YoaPwjO3ARw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=briannorris@chromium.org \
--cc=joe.slater@windriver.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.