From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240E2C433ED for ; Sun, 25 Apr 2021 18:37:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F28C61260 for ; Sun, 25 Apr 2021 18:37:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F28C61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lajcx-0004lq-Or for qemu-devel@archiver.kernel.org; Sun, 25 Apr 2021 14:37:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lajaN-0003nT-7Q for qemu-devel@nongnu.org; Sun, 25 Apr 2021 14:34:27 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:37881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lajaL-0000Ry-FH for qemu-devel@nongnu.org; Sun, 25 Apr 2021 14:34:26 -0400 Received: by mail-ej1-x634.google.com with SMTP id w3so81138693ejc.4 for ; Sun, 25 Apr 2021 11:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g8t70h9neWXabhA//P1LgoFjTn5Db0mQa9V1eENfqW8=; b=rThIx779kruX9rwBAioOVCerOoi/LTR37Q7ZOxHDY52yXqErVxWHOJqDRZKeRIyUuz Zk1m7QWcGakC1o6NsLRkxk8fUzke5RBIm98TmpAPIMflYkb7jz17MFnETH83crGG9fYK xGVMAdwZz4aRWBuggOQHIkdup7AL49Dx8t0uJetuwPpU0wbSjY6TRqzc6xxFGQa7ICLu TAqDmN9V1b96Iz9o4pNgIawLif8q4sUioMEr08AakSq4k3P59SCBdvyGhFTjJ5T6kThI L4sqr7kRRspIEBQjH0JsG1Z6om2vXWZGpP8LJip3LH/atyfT6KjawF4N/c3kPkD+UnsQ f5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g8t70h9neWXabhA//P1LgoFjTn5Db0mQa9V1eENfqW8=; b=DCtSWLNcXqH/pmo5JufV30qM6vfei7wT/+aGzhPG5eb4L7HN1SGT4m5Q0tj7v6m9BD mZ9nHr0/oyu0SK3lV7wMYy3QvUwBLErTZiHfh34DjFMkFWta0hbBBTqnNK5DsudsCsmQ q5/Fh+Gd8zUcsZAKc8ykdPwIzfnd/xCHGCGMc2TFlV+Wgbfv3zbIGVBfHC2aQwDZtp4V 3IKUGltdPUYMwWWI6SdYakpGMoPUC40uHm4xsx+Ajv77xjN4epapiVoKdFGn9LQxbffH fbUedWAhtSF4kT9bS62DOo+VAD8L3pwZKpT8glVwbfZ43AZMIat+8P6thZeNIIh0byLP UO3w== X-Gm-Message-State: AOAM532+UH0oQM+KhUg7nJxnN5qjNVY9VM2telOmBEag7omhRu74f+lS V+6p+QEaFx6RqN7TwlSpp0bMKsGFF4ep9/DsbpaY4g== X-Google-Smtp-Source: ABdhPJwr5emE06mTiExCeLzOTkVOPIU2xVWZQ314TqlNLeh7/vwzjCNVVOofZTVdxBTxJ6KA10RA4GYpHsbpIoL+oM0= X-Received: by 2002:a17:906:6d41:: with SMTP id a1mr14891202ejt.482.1619375662832; Sun, 25 Apr 2021 11:34:22 -0700 (PDT) MIME-Version: 1.0 References: <87y2datpyw.fsf@dusky.pond.sub.org> <5570bf5a-3cab-c30c-2c21-0ab02543199e@amsat.org> <2f4155ca-ee84-75f0-8b35-aac6b18ee4f0@amsat.org> <3dcb8efa-8f6b-0f45-a753-cc58d3bf9855@amsat.org> <87im4cb6ag.fsf@dusky.pond.sub.org> In-Reply-To: From: Peter Maydell Date: Sun, 25 Apr 2021 19:33:25 +0100 Message-ID: Subject: Re: Resetting non-qdev children in a 3-phase reset device To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Eduardo Habkost , "Michael S. Tsirkin" , QEMU Developers , Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, 24 Apr 2021 at 14:04, Philippe Mathieu-Daud=C3=A9 = wrote: > I now understand better the diag288 case, but I still don't understand > the TYPE_APIC one. It has no DeviceClass::reset(), its abstract parent > TYPE_APIC_COMMON register apic_reset_common() but being TYPE_DEVICE it > is not on a qbus. It is somehow connected to the X86CPU object, but the > single call to apic_init_reset() is from do_cpu_init() - not a reset > method -. pc_machine_reset() calls device_legacy_reset(cpu->apic_state) which is to say it invokes the DeviceState::reset method, which is either kvm_apic_reset or apic_reset_common. thanks -- PMM