All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers
Date: Mon, 24 Feb 2014 15:45:13 +0000	[thread overview]
Message-ID: <CAFEAcA_a4CqBum9XVo_G7Xa3oC0OzmANeRx103tDBEoLmSRrHQ@mail.gmail.com> (raw)
In-Reply-To: <5306FD28.8000104@web.de>

On 21 February 2014 07:15, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2014-02-18 16:28, Peter Maydell wrote:
>> The ethernet device in the musicpal only has two tx queues,
>> but we modelled it with four CTDP registers, presumably a
>> cut and paste from the rx queue registers. Since the tx_queue[]
>> array is only 2 entries long this allowed a guest to overrun
>> this buffer. Remove the nonexistent registers.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Acked-by: Jan Kiszka <jan.kiszka@web.de>

Thanks, applied to target-arm.next (with added cc:stable line).

-- PMM

  reply	other threads:[~2014-02-24 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 15:28 [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers Peter Maydell
2014-02-21  7:15 ` Jan Kiszka
2014-02-24 15:45   ` Peter Maydell [this message]
2014-02-24 15:55     ` Andreas Färber
2014-02-24 16:02       ` Peter Maydell
2014-02-24 18:50         ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_a4CqBum9XVo_G7Xa3oC0OzmANeRx103tDBEoLmSRrHQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=jan.kiszka@web.de \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.