From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnbq-0005Gg-40 for qemu-devel@nongnu.org; Fri, 14 Dec 2018 08:34:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXnbp-0001kL-1C for qemu-devel@nongnu.org; Fri, 14 Dec 2018 08:34:30 -0500 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:42468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXnbo-0001jZ-Ie for qemu-devel@nongnu.org; Fri, 14 Dec 2018 08:34:28 -0500 Received: by mail-ot1-x344.google.com with SMTP id v23so5366082otk.9 for ; Fri, 14 Dec 2018 05:34:28 -0800 (PST) MIME-Version: 1.0 References: <20181213223737.11793-1-pbonzini@redhat.com> <20181213223737.11793-3-pbonzini@redhat.com> In-Reply-To: <20181213223737.11793-3-pbonzini@redhat.com> From: Peter Maydell Date: Fri, 14 Dec 2018 13:34:14 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Developers , Stefan Hajnoczi , Kevin Wolf , Max Reitz , Stefan Weil , viktor.prutyanov@phystech.edu, Richard Henderson , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Amit Shah , "Michael S. Tsirkin" , Stefano Stabellini , Anthony PERARD , andrzej zaborowski , Gerd Hoffmann , Eduardo Habkost , Marcel Apfelbaum , John Snow , Aurelien Jarno , Aleksandar Markovic , Stefan Markovic , Jason Wang , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Dmitry Fleytman , David Gibson , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Fam Zheng , Magnus Damm , Igor Mammedov , Riku Voipio , Laurent Vivier , Eric Blake , Thomas Huth , "Edgar E. Iglesias" , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Daniel P. Berrange" , Qemu-block , qemu-arm , "open list:X86" , qemu-ppc On Thu, 13 Dec 2018 at 22:38, Paolo Bonzini wrote: > > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be exempted from the check. > Outside those, after this patch the following files still contain both > 8-space and TAB sequences at the beginning of the line. Many of them > have a majority of TABs, or were initially committed with all tabs. > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 17f1b49d11..ad6fa8e3c6 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1854,7 +1854,7 @@ static const TypeInfo virt_machine_info = { > .instance_size = sizeof(VirtMachineState), > .class_size = sizeof(VirtMachineClass), > .class_init = virt_machine_class_init, > - .instance_init = virt_instance_init, > + .instance_init = virt_instance_init, > .interfaces = (InterfaceInfo[]) { > { TYPE_HOTPLUG_HANDLER }, > { } This one gets the alignment wrong -- the person who wrote that must have had tabs set to 4-space. Eduardo has sent a patch which fixes it up ("virt: Fix broken indentation"), which I've queued, so this is just a heads-up about the resulting trivial conflict. thanks -- PMM