All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, Greg Kurz <groug@kaod.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, qemu-ppc <qemu-ppc@nongnu.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 3/3] dtc: Update to version 1.6.1
Date: Fri, 1 Oct 2021 10:57:18 +0100	[thread overview]
Message-ID: <CAFEAcA_efGE90RywrBjJXi+B=x7wHBCh_RtGaTxdVyWm=rYT6w@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-_6BYX-MZ6LL0c4xJcqyz_EbOWeBGbteMByvERFq4_Xg@mail.gmail.com>

On Fri, 1 Oct 2021 at 10:51, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 1 Oct 2021 at 10:44, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > On Fri, Oct 01, 2021 at 10:37:51AM +0100, Peter Maydell wrote:
> > > I agree in general, but (per the commit message here) our dtc
> > > submodule is currently pointing at some random not-a-release
> > > commit in upstream dtc. We should at least move forward to
> > > whatever the next released dtc after that is, before we say
> > > "no more dtc updates".
> >
> > Yep, if we want to fix it onto an official version tag, that's
> > OK, just not jumping right to very latest version. We might want
> > to move it backwards to better align with what we're targetting
> > in the support
>
> The reason for the last update to the dtc submodule was not
> for any specific external API requirement, but in order to
> get a change we needed to get it to build more cleanly when
> building it as a submodule (QEMU commit 67953a379e). To
> not regress that, we need upstream dtc commit 85e5d839847a.

...having said that, looking at meson.build it looks like it
now ignores dtc's own Makefile and hardcodes how to build
libfdt, including a list of the source files. This seems
pretty fragile to me, but perhaps it means we don't care
any more about whether dtc's Makefile has the commit
85e5d839847a fix...

-- PMM


  reply	other threads:[~2021-10-01  9:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 12:08 [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Thomas Huth
2021-08-27 12:08 ` [PATCH 1/3] meson.build: Fix the check for a usable libfdt Thomas Huth
2021-08-27 12:09 ` [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt Thomas Huth
2021-08-27 13:05   ` Philippe Mathieu-Daudé
2021-08-27 12:09 ` [PATCH 3/3] dtc: Update to version 1.6.1 Thomas Huth
2021-09-30  7:10   ` Thomas Huth
2021-09-30 11:56     ` Greg Kurz
2021-10-01  1:42       ` David Gibson
2021-10-01  1:41     ` David Gibson
2021-10-01  9:08     ` Daniel P. Berrangé
2021-10-01  9:37       ` Peter Maydell
2021-10-01  9:44         ` Daniel P. Berrangé
2021-10-01  9:51           ` Peter Maydell
2021-10-01  9:57             ` Peter Maydell [this message]
2021-10-01 11:41           ` Thomas Huth
2021-10-02  4:35             ` David Gibson
2021-10-01 17:54           ` Brad Smith
2021-10-01 18:08             ` Brad Smith
2021-08-27 12:22 ` [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1 Marc-André Lureau
2021-08-27 15:17 ` [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_efGE90RywrBjJXi+B=x7wHBCh_RtGaTxdVyWm=rYT6w@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=groug@kaod.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.