All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes
Date: Mon, 8 Feb 2016 21:16:16 +0000	[thread overview]
Message-ID: <CAFEAcA_ewHyt-CHr=wm=WAUPeJ8TAfs-yFzK6k9vb84QRjJjug@mail.gmail.com> (raw)
In-Reply-To: <56B8FFE1.60206@redhat.com>

On 8 February 2016 at 20:51, Eric Blake <eblake@redhat.com> wrote:
> On 02/08/2016 11:49 AM, Peter Maydell wrote:
>
>>  122 files changed, 122 insertions(+), 202 deletions(-)
>
> You may want to wait for other maintainers to chime in for files they
> care about; but I looked through the patch and nothing jumped out at me
> as being incorrect.  Many of the files already includes libqtest.c or
> even osdep.h - for those files, the change is obviously correct.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Tested-by: Eric Blake <eblake@redhat.com>
>
>> +++ b/tests/multiboot/libc.c
>> @@ -20,6 +20,7 @@
>>   * THE SOFTWARE.
>>   */
>>
>> +#include "qemu/osdep.h"
>>  #include "libc.h"
>>
>>  void* memcpy(void *dest, const void *src, int n)
>
> Not so sure about this directory.

Good catch, will drop.

thanks
-- PMM

  reply	other threads:[~2016-02-08 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 18:49 [Qemu-devel] [PATCH 0/2] tests: clean includes Peter Maydell
2016-02-08 18:49 ` [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally Peter Maydell
2016-02-08 20:32   ` Eric Blake
2016-02-08 18:49 ` [Qemu-devel] [PATCH 2/2] tests: Clean up includes Peter Maydell
2016-02-08 20:51   ` Eric Blake
2016-02-08 21:16     ` Peter Maydell [this message]
2016-02-09 10:54 ` [Qemu-devel] [PATCH 0/2] tests: clean includes Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_ewHyt-CHr=wm=WAUPeJ8TAfs-yFzK6k9vb84QRjJjug@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.