From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5A8C433F5 for ; Mon, 13 Sep 2021 08:54:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C8E60F6D for ; Mon, 13 Sep 2021 08:54:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E9C8E60F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPhjW-0007S4-2d for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 04:54:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPhfe-00054f-ML for qemu-devel@nongnu.org; Mon, 13 Sep 2021 04:50:36 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPhfb-0006ZG-54 for qemu-devel@nongnu.org; Mon, 13 Sep 2021 04:50:34 -0400 Received: by mail-wr1-x42a.google.com with SMTP id d6so13376932wrc.11 for ; Mon, 13 Sep 2021 01:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=08eP+0Wy8C9Y+icNfsIYmS8byb2MUuvsGf1B8iV7bY4=; b=Ho2WrG7ybyiqDfTEsZp6zIeD0BieVFY/5J/lSfoV/4YUXDevlLzf0GQTLwayNUt3tw RQJD/9mit8Aa3bj+mpLzXINzy9i/1IyFA6H0rSt+wvqXCNskW2QQBQ9JwyTmCp/kmNEx 6FFtrJqsyU/8FPuMLFvwqfmWR4ipCJIwPw+VQk8sZPTMkEiUaPJHeMufXXcueWQF6IH9 d5LWsAI+1xkIdsJGJnOQBmxQfg3CDxBGwWlvW36zV3NPpz5HfHhD8vmt+lVi5v3Ud4WE Bve2HIDQuXks4cD+edvslbx+tY7ZT78k8D5yLDRSQp7ErEscnCoSeXxQS0V8mWbB+WHY mTGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=08eP+0Wy8C9Y+icNfsIYmS8byb2MUuvsGf1B8iV7bY4=; b=wT/1UNVDP86Gl/00l1zLGGD9KnIBEUwfXa0E34NBDVq8oa6SuNy3n3IfHVrKHDdAsc MNJq23toVz90tU37IWz0ZNuJFNy5yv5rfpMRiDvYR0IFFNpKIvkdGv615J/fEdRrBboL Gx3dKJL2uRhuDbL5yvyajw0kNw97BjED9TlImrAwj92+W3se2yfslug6aqWI5Hexd0LU XJKu+zkK95lyXGgK9zmC7NvH+ghqYCvXP4yf6a14HdEG4CIVh7d/BleSMihkSJSaELmJ rAyF9Mhwskuxa6SL/ZhO7p+pEIGVhYPVGmdJ2uJBxGTjTET//NabJp7Vqqw4Zn8RQ0Ts 4IeA== X-Gm-Message-State: AOAM530Xq+d9KSeUoZn+FfxjpjrcbIzCWKqvncczhwqysSOboJ0f8KX9 0Ah3WlXFHSaFN8VjF/FeCn8LnsgJAU+9eqIREUBZ3Q== X-Google-Smtp-Source: ABdhPJxcAWNjLiDG/t64nXFnEalO1Fhb1FEnvMLjfgZxJzNLYY21KboBfSj59YURiQNirBbiOelCn6UYSjEVzFwFRJE= X-Received: by 2002:a5d:4a08:: with SMTP id m8mr10993767wrq.263.1631523029493; Mon, 13 Sep 2021 01:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20210912230757.41096-1-agraf@csgraf.de> <20210912230757.41096-2-agraf@csgraf.de> In-Reply-To: <20210912230757.41096-2-agraf@csgraf.de> From: Peter Maydell Date: Mon, 13 Sep 2021 09:49:39 +0100 Message-ID: Subject: Re: [PATCH v9 01/11] arm: Move PMC register definitions to cpu.h To: Alexander Graf Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , Peter Collingbourne , Richard Henderson , QEMU Developers , Cameron Esfahani , Roman Bolshakov , qemu-arm , Frank Yang , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 13 Sept 2021 at 00:07, Alexander Graf wrote: > > We will need PMC register definitions in accel specific code later. > Move all constant definitions to common arm headers so we can reuse > them. > > Signed-off-by: Alexander Graf > --- > target/arm/cpu.h | 44 ++++++++++++++++++++++++++++++++++++++++++++ > target/arm/helper.c | 44 -------------------------------------------- > 2 files changed, 44 insertions(+), 44 deletions(-) Do these need to be in cpu.h, or would target/arm/internals.h be good enough? (Lots of files all over the codebase include cpu.h, so if the only users of these defines and functions are in target/arm, internals.h is better.) -- PMM