All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH] hw/mips/jazz: Map the UART devices unconditionally
Date: Tue, 29 Jun 2021 10:00:04 +0100	[thread overview]
Message-ID: <CAFEAcA_gmmhWAA3vej7OyOVn1eKNJE-zSeur49wr_Bek8cG0jg@mail.gmail.com> (raw)
In-Reply-To: <20210629053704.2584504-1-f4bug@amsat.org>

On Tue, 29 Jun 2021 at 06:37, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> When using the Magnum ARC firmware we can see accesses to the
> UART1 beeing rejected, because the device is not mapped:

"being"

>
>   $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007001, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007002, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007003, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
>
> Since both UARTs are present (soldered on the board) regardless there

"regardless of whether there are"

> are character devices connected, map them unconditionally.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(This code pre-dated commit 12051d82f004 which made it safe to pass NULL
in as a chardev to serial devices.)

thanks
-- PMM


  reply	other threads:[~2021-06-29  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  5:37 [PATCH] hw/mips/jazz: Map the UART devices unconditionally Philippe Mathieu-Daudé
2021-06-29  9:00 ` Peter Maydell [this message]
2021-07-01 21:21 ` Philippe Mathieu-Daudé
2021-07-03  5:20   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_gmmhWAA3vej7OyOVn1eKNJE-zSeur49wr_Bek8cG0jg@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.