From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjWue-00065s-2t for qemu-devel@nongnu.org; Thu, 02 Mar 2017 15:01:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjWud-0006yM-Fj for qemu-devel@nongnu.org; Thu, 02 Mar 2017 15:01:20 -0500 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:35908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjWud-0006xb-9e for qemu-devel@nongnu.org; Thu, 02 Mar 2017 15:01:19 -0500 Received: by mail-wr0-x229.google.com with SMTP id u108so60333522wrb.3 for ; Thu, 02 Mar 2017 12:01:19 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Peter Maydell Date: Thu, 2 Mar 2017 20:00:57 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: QEMU Developers , QEMU Trivial , Aurelien Jarno On 25 February 2017 at 21:47, BALATON Zoltan wrote: > Clients normally only write to these registers, nothing is known to > ever read them but they are documented as read/write so allow clients > to also read the values. > > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Oh, the read code is in a separate patch? Please put all the handling for a particular register in the same patch. If you think the resulting patch is too long you can split it into several patches each of which handles a group of registers if you like (but it probably isn't necessary). thanks -- PMM