All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests
Date: Fri, 22 Feb 2019 16:34:15 +0000	[thread overview]
Message-ID: <CAFEAcA_qwuZFYkkrZ+BavjoNs48aPuArQsFYCX5G32=JN7542Q@mail.gmail.com> (raw)
In-Reply-To: <20190222105159-mutt-send-email-mst@kernel.org>

On Fri, 22 Feb 2019 at 15:53, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Feb 22, 2019 at 03:47:36PM +0000, Peter Maydell wrote:
> > Compile failure on clang:
> >
> > /home/petmay01/linaro/qemu-for-merges/hw/virtio/virtio-balloon.c:40:3:
> > error: redefinition of typedef 'PartiallyBalloonedPage' is a C11
> > feature [-Werror,-Wtypedef-redefinition]
> > } PartiallyBalloonedPage;
> >   ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/virtio/virtio-balloon.h:33:39:
> > note: previous definition is here
> > typedef struct PartiallyBalloonedPage PartiallyBalloonedPage;
> >                                       ^
> > 1 error generated.
> > /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> > 'hw/virtio/virtio-balloon.o' failed

> Fixed up and re-pushed.
> David, pls note above and don't add duplicate typedefs in the future.
> There's always include/qemu/typedefs.h if you don't know where
> to put a typedef.

It's an easy mistake to make, and it's only clang that complains -- I
did it myself the other week :-)

thanks
-- PMM

  reply	other threads:[~2019-02-22 16:34 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  2:40 [Qemu-devel] [PULL 00/26] pci, pc, virtio: fixes, cleanups, tests Michael S. Tsirkin
2019-02-22 15:47 ` Peter Maydell
2019-02-22 15:53   ` Michael S. Tsirkin
2019-02-22 16:34     ` Peter Maydell [this message]
2019-02-24  0:34     ` Michael S. Tsirkin
2019-02-24 10:21       ` Peter Maydell
2019-02-24 16:41         ` Michael S. Tsirkin
2019-02-25 16:23           ` Philippe Mathieu-Daudé
2019-02-25 17:27             ` Peter Maydell
2019-02-24 22:49     ` David Gibson
2019-02-25 15:19 ` [Qemu-devel] [PULL v2 resend " Michael S. Tsirkin
2019-03-04 10:55   ` Paolo Bonzini
2019-03-04 13:38     ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2019-02-14  4:39 [Qemu-devel] [PATCH 0/5] Improve balloon handling of pagesizes other than 4kiB David Gibson
2019-02-14  4:39 ` [Qemu-devel] [PATCH 1/5] virtio-balloon: Remove unnecessary MADV_WILLNEED on deflate David Gibson
2019-02-28 13:36   ` Michael S. Tsirkin
2019-03-05  0:52     ` David Gibson
2019-03-05  2:29       ` Michael S. Tsirkin
2019-03-05  5:03         ` David Gibson
2019-03-05 14:41           ` Michael S. Tsirkin
2019-03-05 23:35             ` David Gibson
2019-03-06  0:14               ` Michael S. Tsirkin
2019-03-06  0:58                 ` David Gibson
2019-02-14  4:39 ` [Qemu-devel] [PATCH 2/5] virtio-balloon: Corrections to address verification David Gibson
2019-02-22  9:08   ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-02-24 23:37     ` David Gibson
2019-02-25  9:26       ` Greg Kurz
2019-02-26 23:20         ` David Gibson
2019-02-28  9:09           ` Greg Kurz
2019-02-14  4:39 ` [Qemu-devel] [PATCH 3/5] virtio-balloon: Rework ballon_page() interface David Gibson
2019-02-14  4:39 ` [Qemu-devel] [PATCH 4/5] virtio-balloon: Use ram_block_discard_range() instead of raw madvise() David Gibson
2019-02-14  4:39 ` [Qemu-devel] [PATCH 5/5] virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host page size David Gibson
2019-03-05 16:06   ` [Qemu-devel] [PULL 23/26] " Peter Maydell
2019-03-05 23:33     ` David Gibson
2019-02-28 13:39 ` [Qemu-devel] [PATCH 0/5] Improve balloon handling of pagesizes other than 4kiB Michael S. Tsirkin
2019-03-05  0:53   ` David Gibson
2019-03-05  2:13     ` Michael S. Tsirkin
2019-03-05  4:55       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA_qwuZFYkkrZ+BavjoNs48aPuArQsFYCX5G32=JN7542Q@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.