From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49504)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y9D87-0004Mb-CQ
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 08:28:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y9D83-0008TN-DR
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 08:28:03 -0500
Received: from mail-lb0-f173.google.com ([209.85.217.173]:57827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Y9D83-0008TH-6s
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 08:27:59 -0500
Received: by mail-lb0-f173.google.com with SMTP id z12so2833827lbi.4
	for <qemu-devel@nongnu.org>; Thu, 08 Jan 2015 05:27:58 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1420550957-22337-1-git-send-email-marcel@redhat.com>
References: <1420550957-22337-1-git-send-email-marcel@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 8 Jan 2015 13:27:38 +0000
Message-ID: <CAFEAcA_rUfjJJ7oXC-4YzLBWj9D0dXDwXuu5Ff1CyFAMkAsBrQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a
 Qemu crash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On 6 January 2015 at 13:29, Marcel Apfelbaum <marcel@redhat.com> wrote:
> Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option
> descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties.
>
> This resulted in a Qemu crash:
> $ qemu-system-x86_64 -usb
> qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper:
> Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.
> Aborted (core dumped)

> Based on the comments I will receive, I will continue to fix the options
> properties in the same way.

So does this mean that we still have other broken options? Do we
have a timescale for fixing them? I was hoping to be able to commit
a patchset fixing these regressions this week; if we can't do that
then we should probably revert the original changes instead :-(

-- PMM