From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08PC-0003qQ-VR for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:04:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X08P4-0008MZ-Gr for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:03:54 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:63098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X08P4-0008MN-9E for qemu-devel@nongnu.org; Thu, 26 Jun 2014 08:03:46 -0400 Received: by mail-la0-f42.google.com with SMTP id pn19so1801797lab.1 for ; Thu, 26 Jun 2014 05:03:45 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53AB1E8E.2030404@weilnetz.de> References: <1403683241-20678-1-git-send-email-imammedo@redhat.com> <87vbrpe4qa.fsf@blackfin.pond.sub.org> <20140625135126.64cc15d8@nial.usersys.redhat.com> <53AB1E8E.2030404@weilnetz.de> From: Peter Maydell Date: Thu, 26 Jun 2014 13:03:25 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , Igor Mammedov , Paolo Bonzini , Markus Armbruster , QEMU Developers On 25 June 2014 20:10, Stefan Weil wrote: > Am 25.06.2014 13:51, schrieb Igor Mammedov: >> On Wed, 25 Jun 2014 11:08:29 +0200 >> Markus Armbruster wrote: >> >>> Igor Mammedov writes: >>> >>>> Signed-off-by: Igor Mammedov >>> >>> Broken in commit 9005b2a (author cc'ed). Bites only when passed zero >>> len, which seems unlikely. >>> >>> Reviewed-by: Markus Armbruster >>> >> >> main motivation for the patch was to allow -Werror=all build pass. >> > > As I sent an identical patch some minutes ago, I can add > > Reviewed-by: Stefan Weil Applied to master as a buildfix; thanks. -- PMM