All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] reminder: please include justification/explanation for any pull request after rc2
Date: Wed, 6 Dec 2017 20:14:35 +0000	[thread overview]
Message-ID: <CAFEAcA_u2-NTsXPg8dBS8fWd53BSLRVH4ja6HjrAJx5BE+i3sQ@mail.gmail.com> (raw)

Hi; I just wanted to send out a general email to ask submaintainers
who send me pullrequests for patches to go in after about rc2 to
make sure they include a justification and explanation of why the
bugs being fixed mean the changes need to go into the release.
I realized that I wasn't sure if I'd ever actually explicitly
asked people to do that, hence this mail.

The way our process works is that at the start of the rc cycle
we put in pretty much any bug fix, and as we move forwards the
bar gets steadily higher (so we prefer bug fixes that are simple,
that clearly don't affect other subsystems, that fix regressions
since the previous release, and so on), until by the last rc we
are very reluctant indeed to put in any more code.

I've had a few pull requests this cycle where the maintainer hasn't
put a clear explanation in the cover letter of why the patches
need to go into the release. I don't have a good grasp of every
subsystem and usually haven't been following the mailing list
threads, so I won't know whether the bugs being fixed are important
or trivial, risky or very safe. So I have to send an email
asking for clarification and get a reply, which can waste a day
if there are timezone differences or other delays.

So if people could make sure they write good cover letters that
give me the context I need for managing the release process,
that will make my job easier and the whole thing smoother.

thanks
-- PMM

                 reply	other threads:[~2017-12-06 20:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_u2-NTsXPg8dBS8fWd53BSLRVH4ja6HjrAJx5BE+i3sQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.