From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756476AbaCDHsl (ORCPT ); Tue, 4 Mar 2014 02:48:41 -0500 Received: from mail-ve0-f182.google.com ([209.85.128.182]:44014 "EHLO mail-ve0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756457AbaCDHsj (ORCPT ); Tue, 4 Mar 2014 02:48:39 -0500 MIME-Version: 1.0 In-Reply-To: <20140303140811.GA18828@console-pimps.org> References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-7-git-send-email-leif.lindholm@linaro.org> <20140213112606.GF20717@console-pimps.org> <20140303140811.GA18828@console-pimps.org> Date: Mon, 3 Mar 2014 23:48:39 -0800 Message-ID: Subject: Re: [PATCH 06/22] Add helper functions used by arm/arm64 From: Roy Franz To: Matt Fleming Cc: Leif Lindholm , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "linux-efi@vger.kernel.org" , Patch Tracking Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 3, 2014 at 6:08 AM, Matt Fleming wrote: > On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote: >> >> The get_dram_base() function is only used by arm/arm64, but >> there is nothing architecture specific about it, which is why I put it >> here to begin with. I don't feel strongly about this either way. > > Sorry Roy, I just realised that you probably wanted a response from me > about this last point. > > OK, leaving get_dram_base() in efi-stub-helper.c is fine. > > FYI, "NUL" isn't a typo, > >> - options_size++; /* NUL termination */ > [...] >> + options_size++; /* NULL termination */ > > http://en.wikipedia.org/wiki/Null_character > > -- > Matt Fleming, Intel Open Source Technology Center Thanks - I'll take care of this in the next revision. Roy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roy Franz Subject: Re: [PATCH 06/22] Add helper functions used by arm/arm64 Date: Mon, 3 Mar 2014 23:48:39 -0800 Message-ID: References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-7-git-send-email-leif.lindholm@linaro.org> <20140213112606.GF20717@console-pimps.org> <20140303140811.GA18828@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140303140811.GA18828-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Leif Lindholm , Linux Kernel Mailing List , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Patch Tracking List-Id: linux-efi@vger.kernel.org On Mon, Mar 3, 2014 at 6:08 AM, Matt Fleming wrote: > On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote: >> >> The get_dram_base() function is only used by arm/arm64, but >> there is nothing architecture specific about it, which is why I put it >> here to begin with. I don't feel strongly about this either way. > > Sorry Roy, I just realised that you probably wanted a response from me > about this last point. > > OK, leaving get_dram_base() in efi-stub-helper.c is fine. > > FYI, "NUL" isn't a typo, > >> - options_size++; /* NUL termination */ > [...] >> + options_size++; /* NULL termination */ > > http://en.wikipedia.org/wiki/Null_character > > -- > Matt Fleming, Intel Open Source Technology Center Thanks - I'll take care of this in the next revision. Roy From mboxrd@z Thu Jan 1 00:00:00 1970 From: roy.franz@linaro.org (Roy Franz) Date: Mon, 3 Mar 2014 23:48:39 -0800 Subject: [PATCH 06/22] Add helper functions used by arm/arm64 In-Reply-To: <20140303140811.GA18828@console-pimps.org> References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-7-git-send-email-leif.lindholm@linaro.org> <20140213112606.GF20717@console-pimps.org> <20140303140811.GA18828@console-pimps.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 3, 2014 at 6:08 AM, Matt Fleming wrote: > On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote: >> >> The get_dram_base() function is only used by arm/arm64, but >> there is nothing architecture specific about it, which is why I put it >> here to begin with. I don't feel strongly about this either way. > > Sorry Roy, I just realised that you probably wanted a response from me > about this last point. > > OK, leaving get_dram_base() in efi-stub-helper.c is fine. > > FYI, "NUL" isn't a typo, > >> - options_size++; /* NUL termination */ > [...] >> + options_size++; /* NULL termination */ > > http://en.wikipedia.org/wiki/Null_character > > -- > Matt Fleming, Intel Open Source Technology Center Thanks - I'll take care of this in the next revision. Roy