Re: [PATCH 2/3] cfg80211: fix processing world regdomain when non modular

[Janusz Dziedzic <janusz.dziedzic@gmail.com>]

2014-04-16 12:38 GMT+02:00 Arik Nemtsov <arik@wizery.com>:
> Thanks for testing Colleen!
>
> I'll respin the patch on top of wireless-testing.
>
Please don't remove "Pending regulatory reques ... " dbg print. This
could be usefull for debuging.

BR
Janusz

> Arik
>
> On Mon, Apr 14, 2014 at 10:27 PM, Colleen T <colleen@cozybit.com> wrote:
>> Hello,
>>
>> Applying Arik's patch on top of Luis' resolves our problem.
>>
>> You also get my:
>>
>> Tested-by: Colleen Twitty <colleen@cozybit.com>
>>
>> Thanks,
>> -Colleen
>>
>> On Sun, Apr 13, 2014 at 5:50 AM, Eliad Peller <eliad@wizery.com> wrote:
>>> On Wed, Apr 9, 2014 at 7:33 PM, Arik Nemtsov <arik@wizery.com> wrote:
>>>>
>>>> Seems I might have found the culprit - reg_todo is called while the
>>>> request to CRDA is in flight and the patch in question causes the
>>>> already-in-process user-request to be handled again. Since it's the
>>>> same regdomain as the last request (it's the last request itself), we
>>>> get this:
>>>>
>>>> treatment = __reg_process_hint_user(user_request);
>>>> if (treatment == REG_REQ_IGNORE ||
>>>>    treatment == REG_REQ_ALREADY_SET) {
>>>> kfree(user_request); <------
>>>> return treatment;
>>>> }
>>>>
>>>> Can you try adding the attached patch? It just replaced relevant
>>>> kfree-s with a function that avoids freeing the last request.
>>>>
>>> i encountered a similar panic, and this patch seems to fix it.
>>> so you get my:
>>>
>>> Tested-by: Eliad Peller <eliad@wizery.com>
>>>
>>> Eliad.



-- 
Janusz Dziedzic