From: Morgan Chang <mingdien.chang@gmail.com>
To: Vahram Aharonyan <Vahram.Aharonyan@synopsys.com>,
"John.Youn@synopsys.com" <John.Youn@synopsys.com>
Cc: Robert Baldyga <r.baldyga@samsung.com>,
"balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 1/5] usb: dwc2: gadget: use ep->fifo_index in context of FIFO registers
Date: Mon, 9 Jan 2017 16:13:33 +0800 [thread overview]
Message-ID: <CAFEKEBVJ0OxWc78ik=0SpZ0+4qY8v3TghsghCiEz3BWq8JGgAQ@mail.gmail.com> (raw)
In-Reply-To: <739CB48052CD4F44BB4283AAE6D7CEF2FD2238B0@am04wembxb.internal.synopsys.com>
Hi, John
On Thu, Feb 4, 2016 at 8:25 PM, Vahram Aharonyan
<Vahram.Aharonyan@synopsys.com> wrote:
> On 2/3/2016 3:40 PM, Robert Baldyga wrote:
>
> Hi Robert,
>
> DTXFSTS register is linked with endpoint, not FIFO - it contains information about how much space is used in the FIFO assigned to the endpoint. Changing ep->index to ep->fifo_index will work, if FIFO number assigned to that endpoint coincides with ep->index. For example, TX FIFO #1 has been assigned to EP 1 In. If TX FIFO #2 was assigned to EP #1, then with this change DTXFSTS[2] will be used instead of DTXFSTS[1] for EP #1.
>
> Thanks,
> Vahram.
As mentioned by Vahram, DTXFSTS registers are indexed by endpoint
number, instead of FIFO number.
It should be reverted.
next prev parent reply other threads:[~2017-01-09 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 11:36 [PATCH v2 0/5] usb: dwc2: gadget: Fix TX FIFO handling Robert Baldyga
2016-02-03 11:36 ` [PATCH v2 1/5] usb: dwc2: gadget: use ep->fifo_index in context of FIFO registers Robert Baldyga
2016-02-04 12:25 ` Vahram Aharonyan
2017-01-09 8:13 ` Morgan Chang [this message]
2016-02-03 11:36 ` [PATCH v2 2/5] usb: dwc2: gadget: fix TX FIFO size and address initialization Robert Baldyga
2016-02-04 13:07 ` Vahram Aharonyan
2016-02-03 11:36 ` [PATCH v2 3/5] usb: dwc2: gadget: change variable name to more meaningful Robert Baldyga
2016-02-03 11:36 ` [PATCH v2 4/5] usb: dwc2: gadget: remove dead code from dwc2_hsotg_ep_enable() Robert Baldyga
2016-02-03 11:36 ` [PATCH v2 5/5] usb: dwc2: gadget: free TX FIFO after killing requests Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEKEBVJ0OxWc78ik=0SpZ0+4qY8v3TghsghCiEz3BWq8JGgAQ@mail.gmail.com' \
--to=mingdien.chang@gmail.com \
--cc=John.Youn@synopsys.com \
--cc=Vahram.Aharonyan@synopsys.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.