From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932409AbcDLJkx (ORCPT ); Tue, 12 Apr 2016 05:40:53 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:35807 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753719AbcDLJku (ORCPT ); Tue, 12 Apr 2016 05:40:50 -0400 MIME-Version: 1.0 In-Reply-To: <20160404051638.GR17806@rob-hp-laptop> References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org> <1459589383-16914-7-git-send-email-guodong.xu@linaro.org> <20160404051638.GR17806@rob-hp-laptop> Date: Tue, 12 Apr 2016 17:40:49 +0800 Message-ID: Subject: Re: [PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes From: Guodong Xu To: Rob Herring Cc: Xu Wei , Mark Rutland , Grant Likely , Linus Walleij , Arnd Bergmann , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , XinWei Kong , Zhong Kaihua Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 April 2016 at 13:16, Rob Herring wrote: > On Sat, Apr 02, 2016 at 05:29:33PM +0800, Guodong Xu wrote: >> From: Zhong Kaihua >> >> Add Hi6220 spi configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Signed-off-by: Wei Xu >> --- >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 15 +++++++++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-pinctrl.dtsi | 21 +++++++++++++++++++++ >> 3 files changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> index 985a2ad..5c9ee31 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> @@ -20,6 +20,7 @@ >> serial1 = &uart1; /* BT UART */ >> serial2 = &uart2; /* LS Expansion UART0 */ >> serial3 = &uart3; /* LS Expansion UART1 */ >> + spi0 = &spi_0; > > You shouldn't really need an alias for SPI. Will remove it. > >> }; >> >> chosen { >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index e96cc3c..dcca83b 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -585,5 +585,20 @@ >> clock-names = "apb_pclk"; >> status = "ok"; >> }; >> + >> + spi_0: spi@f7106000 { >> + compatible = "arm,pl022", "arm,primecell"; >> + reg = <0x0 0xf7106000 0x0 0x1000>; >> + interrupts = <0 50 4>; >> + bus-id = <0>; >> + enable-dma = <0>; >> + clocks = <&sys_ctrl HI6220_SPI_CLK>; >> + clock-names = "apb_pclk"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&spi0_pmx_func &spi0_cfg_func>; >> + num-cs = <1>; >> + cs-gpios = <&gpio6 2 0>; >> + status = "ok"; > > You only need an ok to override a disabled status, so I think you can > drop this. Or disable by default and let boards override it if that > makes sense. Thanks. I will modify this to "disabled", and enable it in board dts: hi6220-hikey.dts -Guodong > > Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guodong Xu Subject: Re: [PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes Date: Tue, 12 Apr 2016 17:40:49 +0800 Message-ID: References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org> <1459589383-16914-7-git-send-email-guodong.xu@linaro.org> <20160404051638.GR17806@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160404051638.GR17806@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Xu Wei , Mark Rutland , Grant Likely , Linus Walleij , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-arm-kernel , XinWei Kong , Zhong Kaihua List-Id: devicetree@vger.kernel.org On 4 April 2016 at 13:16, Rob Herring wrote: > On Sat, Apr 02, 2016 at 05:29:33PM +0800, Guodong Xu wrote: >> From: Zhong Kaihua >> >> Add Hi6220 spi configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Signed-off-by: Wei Xu >> --- >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 15 +++++++++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-pinctrl.dtsi | 21 +++++++++++++++++++++ >> 3 files changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> index 985a2ad..5c9ee31 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> @@ -20,6 +20,7 @@ >> serial1 = &uart1; /* BT UART */ >> serial2 = &uart2; /* LS Expansion UART0 */ >> serial3 = &uart3; /* LS Expansion UART1 */ >> + spi0 = &spi_0; > > You shouldn't really need an alias for SPI. Will remove it. > >> }; >> >> chosen { >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index e96cc3c..dcca83b 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -585,5 +585,20 @@ >> clock-names = "apb_pclk"; >> status = "ok"; >> }; >> + >> + spi_0: spi@f7106000 { >> + compatible = "arm,pl022", "arm,primecell"; >> + reg = <0x0 0xf7106000 0x0 0x1000>; >> + interrupts = <0 50 4>; >> + bus-id = <0>; >> + enable-dma = <0>; >> + clocks = <&sys_ctrl HI6220_SPI_CLK>; >> + clock-names = "apb_pclk"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&spi0_pmx_func &spi0_cfg_func>; >> + num-cs = <1>; >> + cs-gpios = <&gpio6 2 0>; >> + status = "ok"; > > You only need an ok to override a disabled status, so I think you can > drop this. Or disable by default and let boards override it if that > makes sense. Thanks. I will modify this to "disabled", and enable it in board dts: hi6220-hikey.dts -Guodong > > Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: guodong.xu@linaro.org (Guodong Xu) Date: Tue, 12 Apr 2016 17:40:49 +0800 Subject: [PATCH v2 06/16] arm64: dts: add Hi6220 spi configuration nodes In-Reply-To: <20160404051638.GR17806@rob-hp-laptop> References: <1459589383-16914-1-git-send-email-guodong.xu@linaro.org> <1459589383-16914-7-git-send-email-guodong.xu@linaro.org> <20160404051638.GR17806@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4 April 2016 at 13:16, Rob Herring wrote: > On Sat, Apr 02, 2016 at 05:29:33PM +0800, Guodong Xu wrote: >> From: Zhong Kaihua >> >> Add Hi6220 spi configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Signed-off-by: Wei Xu >> --- >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 15 +++++++++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-pinctrl.dtsi | 21 +++++++++++++++++++++ >> 3 files changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> index 985a2ad..5c9ee31 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> @@ -20,6 +20,7 @@ >> serial1 = &uart1; /* BT UART */ >> serial2 = &uart2; /* LS Expansion UART0 */ >> serial3 = &uart3; /* LS Expansion UART1 */ >> + spi0 = &spi_0; > > You shouldn't really need an alias for SPI. Will remove it. > >> }; >> >> chosen { >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index e96cc3c..dcca83b 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -585,5 +585,20 @@ >> clock-names = "apb_pclk"; >> status = "ok"; >> }; >> + >> + spi_0: spi at f7106000 { >> + compatible = "arm,pl022", "arm,primecell"; >> + reg = <0x0 0xf7106000 0x0 0x1000>; >> + interrupts = <0 50 4>; >> + bus-id = <0>; >> + enable-dma = <0>; >> + clocks = <&sys_ctrl HI6220_SPI_CLK>; >> + clock-names = "apb_pclk"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&spi0_pmx_func &spi0_cfg_func>; >> + num-cs = <1>; >> + cs-gpios = <&gpio6 2 0>; >> + status = "ok"; > > You only need an ok to override a disabled status, so I think you can > drop this. Or disable by default and let boards override it if that > makes sense. Thanks. I will modify this to "disabled", and enable it in board dts: hi6220-hikey.dts -Guodong > > Rob