From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD8FC76195 for ; Tue, 28 Mar 2023 09:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjC1JWS (ORCPT ); Tue, 28 Mar 2023 05:22:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbjC1JWP (ORCPT ); Tue, 28 Mar 2023 05:22:15 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBBAD59F1 for ; Tue, 28 Mar 2023 02:22:13 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id r187so14175236ybr.6 for ; Tue, 28 Mar 2023 02:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1679995333; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WfEbC+QvlmYRFEpM334dDDmHLZzT53TFZ7pAp7zhwe4=; b=O+6rpHUxMrocg+PNRSUNrl09ruDw8nFucVYoEuKiSkUoYU+rAaaZhtmXvt6TdGkwNP M1b8yBJvevc5Zt7Jyzawt3sUx2+8btHWzfMFZYbqpV5ujpvuCnm6uUn66khGbaDrI4/b BnOZaXOaZ1QBeFNUU7FRBwi2CjsBQzbK8g1XLS5nhmorHOweLMGd0v+/YX2qMdHObYeV flOhgDotNum9SI+7uxyc4MfExqnGRtrmIxceFdg59KEnFajy5Cv80DUd+NdLRx8k3RA4 7LEesg4hoH8OgLFhlxClH+aKYg8loDZNrIsxSLEo9AIGjCJ+YOTdQbIxwY0yUZUkHLT6 Rexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679995333; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WfEbC+QvlmYRFEpM334dDDmHLZzT53TFZ7pAp7zhwe4=; b=ZL5xhIkU6Kr8ROuzjv8CeW/cdx10Cg1a/Y2ejyjTMwkyI+TMGhmxpl/OHbYJOB3hEa EGt309u/lZteg3h/TwnkSSl6KsDadA8celxHFx+whAt0xOUNP9aR2p3pswAWMXgwIdGf 3py3CyQRx9tDcMDBJxCQ3PbFL2OtG1vRqh1IyhBC+jwUGz1xPR+b2uUR7CzkVjbG5wYX 5PVgps39c3SxDX3/3HsVGcC5YHsRpl13PdIdQRQA9WCurAYJMATznrLQB/Qp9gptct/z rqNwN+RlYZ/gBJAgfHlORFlqNrMoI0JnZlh0lGZ0nGwk6fQd3DVAnJrnkY+no9ST1NtL PBNw== X-Gm-Message-State: AAQBX9djxWwpqRXCBr8cwHQeri9GmQ1Ot8foOPDQGaUW+JA7elbKqn60 Xmv3vtMKhQi7dD2AWO6dCo/qY5Gv5s9CGHxuQaUElw== X-Google-Smtp-Source: AKy350auimLGCr8ILoBzGItiYAiR4pgO8LPEdWrnD1Vk5Z4GVtmW4pyg+5kEg5lZTH5zOTSGFwsCl8xX2CPkdVQT06U= X-Received: by 2002:a25:a2c3:0:b0:b78:1b26:a642 with SMTP id c3-20020a25a2c3000000b00b781b26a642mr6658558ybn.1.1679995333140; Tue, 28 Mar 2023 02:22:13 -0700 (PDT) MIME-Version: 1.0 References: <20230324094205.33266-1-angelogioacchino.delregno@collabora.com> <20230324094205.33266-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20230324094205.33266-4-angelogioacchino.delregno@collabora.com> From: Alexandre Mergnat Date: Tue, 28 Mar 2023 11:22:02 +0200 Message-ID: Subject: Re: [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type To: AngeloGioacchino Del Regno Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, flora.fu@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Le ven. 24 mars 2023 =C3=A0 10:42, AngeloGioacchino Del Regno a =C3=A9crit : > > In preparation for adding new members with name abbreviations describe > the struct pwrap_slv_type with kerneldoc to enhance human readability. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/= mtk-pmic-wrap.c > index 5c500be48f7c..a33a1b1820cb 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1218,11 +1218,17 @@ struct pwrap_slv_regops { > int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata); > }; > > +/** > + * struct pwrap_slv_type - PMIC device wrapper definitions > + * @dew_regs: Device Wrapper (DeW) register offsets > + * @type: PMIC Type (model) > + * @regops: Register R/W ops > + * @caps: Capability flags for the target device > + */ > struct pwrap_slv_type { > const u32 *dew_regs; > enum pmic_type type; > const struct pwrap_slv_regops *regops; > - /* Flags indicating the capability for the target slave */ > u32 caps; > }; Reviewed-by: Alexandre Mergnat Regards, Alexandre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ECC5C76196 for ; Tue, 28 Mar 2023 09:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Maa3hhsaIrM90O+77ljxN1s9XmQZR3awuSInyI+zwOA=; b=kWXy3/sCqSqm0R orliy1trZzGCcphKhpm1VLrj+2Aol2qs3WTcUytqRh98p8nTOpy1K5YJcXruCafB1Pa115GRq2t59 mlXB1Vi65wewCoybRgA3IawZ1Ml5vxgKHuU8eg4W65C5KTpbMitIyqB1+YQZy73XT21Dt+bA2peQM L8G72YSm4nHifT5XGng3qJ0ODQWvpAodzpK+eHjF3tGZ/6dbDdAihrJueaUGA383haoMHUpdVB9bP ferN0LwFYyNqFFTEFayENodAtUpWxGH6BiEIYkI+zcqBBOWZ3SH35nl7ulGA6Ql17PVcp+RAAUX0/ w2rj2uf0PY895RIskqBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ph5X1-00DivT-1b; Tue, 28 Mar 2023 09:22:19 +0000 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ph5Wy-00DitV-1G for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 09:22:17 +0000 Received: by mail-yb1-xb33.google.com with SMTP id j7so14195980ybg.4 for ; Tue, 28 Mar 2023 02:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1679995333; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WfEbC+QvlmYRFEpM334dDDmHLZzT53TFZ7pAp7zhwe4=; b=O+6rpHUxMrocg+PNRSUNrl09ruDw8nFucVYoEuKiSkUoYU+rAaaZhtmXvt6TdGkwNP M1b8yBJvevc5Zt7Jyzawt3sUx2+8btHWzfMFZYbqpV5ujpvuCnm6uUn66khGbaDrI4/b BnOZaXOaZ1QBeFNUU7FRBwi2CjsBQzbK8g1XLS5nhmorHOweLMGd0v+/YX2qMdHObYeV flOhgDotNum9SI+7uxyc4MfExqnGRtrmIxceFdg59KEnFajy5Cv80DUd+NdLRx8k3RA4 7LEesg4hoH8OgLFhlxClH+aKYg8loDZNrIsxSLEo9AIGjCJ+YOTdQbIxwY0yUZUkHLT6 Rexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679995333; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WfEbC+QvlmYRFEpM334dDDmHLZzT53TFZ7pAp7zhwe4=; b=zoz3ibVNoTQYXXczdWbyZ/Su1xvjn8OCEreYxH8+eJN2G0+ex7ewZuivzj12cuo2dP G62Z49y/qQwGNCeSxgGJw44D4yZneFfQxWQY67bFLFglD+xCVptYRan9Dt0L5hwu1Jy0 Q78lsrNNOcAzu99uZg/WzETF/EoZTZvGYhpfMr6GINlHlgZ6Dl7RoLwXsi9n3+SbJJ6t 1gsPm2x1Cgl4Yv3XZS9UBUMye59bPsvFz1qqRfUZHQvxwtEJGb5epwYglcbLG97tlL+E +cfZDANY5lEexwEmnE6/C8krph1TlmxoblZ8VAVv+P+Ms8j2QWT5l/3iERgo0M/gbXMt tkDg== X-Gm-Message-State: AAQBX9dq8vD5VHrY+tzTg7Y/rJlIdgifmtvWAFT9oPSpyTut8rAEXtjE mT1J/6TnLGH1dTbQpZjXEKVhsIsBmttYTxUbo6OLsA== X-Google-Smtp-Source: AKy350auimLGCr8ILoBzGItiYAiR4pgO8LPEdWrnD1Vk5Z4GVtmW4pyg+5kEg5lZTH5zOTSGFwsCl8xX2CPkdVQT06U= X-Received: by 2002:a25:a2c3:0:b0:b78:1b26:a642 with SMTP id c3-20020a25a2c3000000b00b781b26a642mr6658558ybn.1.1679995333140; Tue, 28 Mar 2023 02:22:13 -0700 (PDT) MIME-Version: 1.0 References: <20230324094205.33266-1-angelogioacchino.delregno@collabora.com> <20230324094205.33266-4-angelogioacchino.delregno@collabora.com> In-Reply-To: <20230324094205.33266-4-angelogioacchino.delregno@collabora.com> From: Alexandre Mergnat Date: Tue, 28 Mar 2023 11:22:02 +0200 Message-ID: Subject: Re: [PATCH v2 3/6] soc: mediatek: pwrap: Add kerneldoc for struct pwrap_slv_type To: AngeloGioacchino Del Regno Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, flora.fu@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_022216_427550_125210CB X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgdmVuLiAyNCBtYXJzIDIwMjMgw6AgMTA6NDIsIEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25v CjxhbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+IGEgw6ljcml0IDoKPgo+ IEluIHByZXBhcmF0aW9uIGZvciBhZGRpbmcgbmV3IG1lbWJlcnMgd2l0aCBuYW1lIGFiYnJldmlh dGlvbnMgZGVzY3JpYmUKPiB0aGUgc3RydWN0IHB3cmFwX3Nsdl90eXBlIHdpdGgga2VybmVsZG9j IHRvIGVuaGFuY2UgaHVtYW4gcmVhZGFiaWxpdHkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmdlbG9H aW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMgfCA4ICsr KysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMgYi9k cml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPiBpbmRleCA1YzUwMGJlNDhmN2Mu LmEzM2ExYjE4MjBjYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1p Yy13cmFwLmMKPiArKysgYi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG1pYy13cmFwLmMKPiBA QCAtMTIxOCwxMSArMTIxOCwxNyBAQCBzdHJ1Y3QgcHdyYXBfc2x2X3JlZ29wcyB7Cj4gICAgICAg ICBpbnQgKCpwd3JhcF93cml0ZSkoc3RydWN0IHBtaWNfd3JhcHBlciAqd3JwLCB1MzIgYWRyLCB1 MzIgd2RhdGEpOwo+ICB9Owo+Cj4gKy8qKgo+ICsgKiBzdHJ1Y3QgcHdyYXBfc2x2X3R5cGUgLSBQ TUlDIGRldmljZSB3cmFwcGVyIGRlZmluaXRpb25zCj4gKyAqIEBkZXdfcmVnczogICAgICBEZXZp Y2UgV3JhcHBlciAoRGVXKSByZWdpc3RlciBvZmZzZXRzCj4gKyAqIEB0eXBlOiAgICAgICAgICBQ TUlDIFR5cGUgKG1vZGVsKQo+ICsgKiBAcmVnb3BzOiAgICAgICAgUmVnaXN0ZXIgUi9XIG9wcwo+ ICsgKiBAY2FwczogICAgICAgICAgQ2FwYWJpbGl0eSBmbGFncyBmb3IgdGhlIHRhcmdldCBkZXZp Y2UKPiArICovCj4gIHN0cnVjdCBwd3JhcF9zbHZfdHlwZSB7Cj4gICAgICAgICBjb25zdCB1MzIg KmRld19yZWdzOwo+ICAgICAgICAgZW51bSBwbWljX3R5cGUgdHlwZTsKPiAgICAgICAgIGNvbnN0 IHN0cnVjdCBwd3JhcF9zbHZfcmVnb3BzICpyZWdvcHM7Cj4gLSAgICAgICAvKiBGbGFncyBpbmRp Y2F0aW5nIHRoZSBjYXBhYmlsaXR5IGZvciB0aGUgdGFyZ2V0IHNsYXZlICovCj4gICAgICAgICB1 MzIgY2FwczsKPiAgfTsKClJldmlld2VkLWJ5OiBBbGV4YW5kcmUgTWVyZ25hdCA8YW1lcmduYXRA YmF5bGlicmUuY29tPgoKUmVnYXJkcywKQWxleGFuZHJlCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==