From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 723F7C433E0 for ; Thu, 2 Jul 2020 10:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A9B020771 for ; Thu, 2 Jul 2020 10:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b="Ga4jYOuv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728197AbgGBKKM (ORCPT ); Thu, 2 Jul 2020 06:10:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727057AbgGBKKL (ORCPT ); Thu, 2 Jul 2020 06:10:11 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20FDDC08C5C1 for ; Thu, 2 Jul 2020 03:10:11 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id b4so25028065qkn.11 for ; Thu, 02 Jul 2020 03:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNkwKZ84Zrawk816auciDQTYwDrs9ybRS0FVRLuLd9I=; b=Ga4jYOuvR8MX3nF2I6L7nPH0rm/ZyxshqRb5F4+rL33+Dnnyb7FevBZZ90KDsvrHKV WgfFd92ZJh5hmBt1OEWYUt4vNpzYROC9C4LhqphBIgEmjRIuA2uLoAqnId7O9xEpBOUs Nla0Wih4ZFy2hHQ3+TBKtg2SY7KBhlFLwmoyxSWCgb0u9AhCwZrAPgE2nWZbdmGIRdHO Bn+d7Dg/YVemE9LvZSnqhR+jUeppn8wUwMia4TUXkC/w3ps8MVS8IgrrSDC0yol2L1RR 2t/1JL25f6Pb6bomI8yC4grazve3xpODK2cXQrPtDv5FgiCe0uQ6kj9ytlhs6OXRwq6F X/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNkwKZ84Zrawk816auciDQTYwDrs9ybRS0FVRLuLd9I=; b=CKye+JRNarVNS1ecMl3M7YjPpl1irH53Rly4FIbO6xjNbrBfHotUZopzc4613290Wh lNkKLor1kr2XUB8ZKIxfFAv1IItPCj1Kev7+ctDXbthd9mNJ97K7Sbke9zj2DLgT9Eny nzy87QON4RqYY/nOl2N4N7zWt+V+0zbrgQE6h02clY9uitiBnqtbNqEDm1ML4aCBhDt0 vheASt58Qje3I7ALTThXy55oUsIhs2nXjgN4/dZ7qOaPgLNnoVday8r2Ywxq2QECrGCJ S/FDNjW4fluRvlMH1fuB6j/UeiKMQ7Nokhslyab8EzrOoOqf2iQEM8EI4yGPmstW8Nk3 r8Kw== X-Gm-Message-State: AOAM5308J09xWd2JLOVDL2jkTXqWWBERLy98f+8TY2mzeRKjn8q4soeA xNc5Y4ky3vd0znZAWx0zeKCQD+aBmApJ1y/UAoNyNg== X-Google-Smtp-Source: ABdhPJxSCrlGDF8VbOkF76c527VsV7+BA6AZM2DosVAXwrPnrjTB9/lEdURnS2JpeZC7MdKZXtTdxC39Y9vZxDerRRc= X-Received: by 2002:a37:2781:: with SMTP id n123mr29703103qkn.106.1593684610371; Thu, 02 Jul 2020 03:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20200521162518.1809995-1-lma@semihalf.com> <3c89e614-81f5-ba87-19a9-fbe9f5c73925@linux.intel.com> <475fb5c0-9b26-a8f6-c102-25c7775bc2ca@linux.intel.com> <268b11b6-9f4c-d769-a7f9-536d77198705@linux.intel.com> <7e38bb2e-2132-d305-e94d-043fa53bd836@linux.intel.com> In-Reply-To: From: =?UTF-8?Q?=C5=81ukasz_Majczak?= Date: Thu, 2 Jul 2020 12:09:59 +0200 Message-ID: Subject: Re: [PATCH v3] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function To: Pierre-Louis Bossart Cc: "N, Harshapriya" , "alsa-devel@alsa-project.org" , Jie Yang , Radoslaw Biernacki , Ross Zwisler , "linux-kernel@vger.kernel.org" , Liam Girdwood , "M R, Sathya Prakash" , Bob Brandt , Marcin Wojtas , Alex Levin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I am also ok with Harsha patch. I have checked it on my Eve and it looks ok= . Best regards, Lukasz =C5=9Br., 1 lip 2020 o 19:08 Pierre-Louis Bossart napisa=C5=82(a): > > > >>> Tested and the following is something we can use without creating a n= ew > >> dailink. > >>> struct snd_soc_dai *codec_dai =3D asoc_rtd_to_codec(rtd, = 0); > >>> if (!strcmp(codec_dai->name, KBL_REALTEK_DMIC_CODEC_DAI)) { > >>> if (params_channels(params) =3D=3D 2 || > >> DMIC_CH(dmic_constraints) =3D=3D 2) > >>> channels->min =3D channels->max =3D 2; > >>> else > >>> channels->min =3D channels->max =3D 4; > >>> } else { > >>> rate->min =3D rate->max =3D 48000; > >>> channels->min =3D channels->max =3D 2; > >>> snd_mask_none(fmt); > >>> snd_mask_set_format(fmt, pcm_fmt); > >>> } > >>> > >>> Pierre, thoughts? > >> > >> thanks Harsha, that looks like what I had in mind, but my earlier ques= tion was > >> why we deal with the rates and formats only in the last case? > > The speaker codec supported only 16 bit. (Vendor mentioned) > > For playback on this platform, only 48Khz was used. > > ok then, as long as Harsha and Lukasz are aligned I'm fine. Thanks! > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A058EC433DF for ; Thu, 2 Jul 2020 10:11:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 075B920772 for ; Thu, 2 Jul 2020 10:11:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iqNmRyBi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b="Ga4jYOuv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 075B920772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=semihalf.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6A7CF16D9; Thu, 2 Jul 2020 12:10:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6A7CF16D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593684671; bh=7zOf0XHFLX0eK3QuQhqBjCbi88LKF6pOiXhH3KqTZ6k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iqNmRyBiNSJlqk0L9EDM+uJN/oSFmHkfrP7wrp5BeVEcGYtS/cqUL4imASCn5ylNr RmUdkAGsgeseHvNCZM/103L3dAHvtHP9s1FUZjzazNATIQ/tKVvG0AQL8pTKbeVquz FfStlefj9s8nyuDpwRen2nMINE9YqxnQk/K8nGGg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 04731F8022B; Thu, 2 Jul 2020 12:10:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0EF03F8022D; Thu, 2 Jul 2020 12:10:19 +0200 (CEST) Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DE797F80134 for ; Thu, 2 Jul 2020 12:10:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DE797F80134 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b="Ga4jYOuv" Received: by mail-qk1-x742.google.com with SMTP id j80so25076085qke.0 for ; Thu, 02 Jul 2020 03:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MNkwKZ84Zrawk816auciDQTYwDrs9ybRS0FVRLuLd9I=; b=Ga4jYOuvR8MX3nF2I6L7nPH0rm/ZyxshqRb5F4+rL33+Dnnyb7FevBZZ90KDsvrHKV WgfFd92ZJh5hmBt1OEWYUt4vNpzYROC9C4LhqphBIgEmjRIuA2uLoAqnId7O9xEpBOUs Nla0Wih4ZFy2hHQ3+TBKtg2SY7KBhlFLwmoyxSWCgb0u9AhCwZrAPgE2nWZbdmGIRdHO Bn+d7Dg/YVemE9LvZSnqhR+jUeppn8wUwMia4TUXkC/w3ps8MVS8IgrrSDC0yol2L1RR 2t/1JL25f6Pb6bomI8yC4grazve3xpODK2cXQrPtDv5FgiCe0uQ6kj9ytlhs6OXRwq6F X/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MNkwKZ84Zrawk816auciDQTYwDrs9ybRS0FVRLuLd9I=; b=mcUBfrCCAH2k2Ge3j2OGB87Jai6sY2O4hR4HL5ghHuqR87Ns/jho6OzET5cRckiIL6 RPf52j/MiowqcgTDq46apFSH+ByJCsgK7FJCxLsAWUMr+Cr70+ComKuuohzRLWm/OP6v 0lPPn7x8cjoDAebC/3XkQUR55jyxo4fQbWI6CSqZh85wXd0JRjDirOl3OFQyjwBbQzOs GPJ/Kj0EPIYB/HGtY4o9p8lYFniRBD3smSM2JH7V+jxrxzjV+6XYvUy533jAZ/y+bDEK V1cqlhNzTJhBRc7x2SdM1rk5dYCiRRCfUuIVLoUsnsLlChNoU+Oeth/TeKkScb5VkoN1 wZ0w== X-Gm-Message-State: AOAM530LvwBY+aAi2o2nrgxyKjfn3HBW0Ouiag8kdu1+ECitBRI90G0U 5AHOVDXdNkOIGW8z5+CNn6G0pUSvn8RP2EZ74WsYjg== X-Google-Smtp-Source: ABdhPJxSCrlGDF8VbOkF76c527VsV7+BA6AZM2DosVAXwrPnrjTB9/lEdURnS2JpeZC7MdKZXtTdxC39Y9vZxDerRRc= X-Received: by 2002:a37:2781:: with SMTP id n123mr29703103qkn.106.1593684610371; Thu, 02 Jul 2020 03:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20200521162518.1809995-1-lma@semihalf.com> <3c89e614-81f5-ba87-19a9-fbe9f5c73925@linux.intel.com> <475fb5c0-9b26-a8f6-c102-25c7775bc2ca@linux.intel.com> <268b11b6-9f4c-d769-a7f9-536d77198705@linux.intel.com> <7e38bb2e-2132-d305-e94d-043fa53bd836@linux.intel.com> In-Reply-To: From: =?UTF-8?Q?=C5=81ukasz_Majczak?= Date: Thu, 2 Jul 2020 12:09:59 +0200 Message-ID: Subject: Re: [PATCH v3] ASoC: Intel: kbl_rt5663_rt5514_max98927: Split be_hw_params_fixup function To: Pierre-Louis Bossart Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "alsa-devel@alsa-project.org" , "N, Harshapriya" , Jie Yang , Radoslaw Biernacki , Ross Zwisler , "linux-kernel@vger.kernel.org" , Liam Girdwood , "M R, Sathya Prakash" , Bob Brandt , Marcin Wojtas , Alex Levin X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, I am also ok with Harsha patch. I have checked it on my Eve and it looks ok= . Best regards, Lukasz =C5=9Br., 1 lip 2020 o 19:08 Pierre-Louis Bossart napisa=C5=82(a): > > > >>> Tested and the following is something we can use without creating a n= ew > >> dailink. > >>> struct snd_soc_dai *codec_dai =3D asoc_rtd_to_codec(rtd, = 0); > >>> if (!strcmp(codec_dai->name, KBL_REALTEK_DMIC_CODEC_DAI)) { > >>> if (params_channels(params) =3D=3D 2 || > >> DMIC_CH(dmic_constraints) =3D=3D 2) > >>> channels->min =3D channels->max =3D 2; > >>> else > >>> channels->min =3D channels->max =3D 4; > >>> } else { > >>> rate->min =3D rate->max =3D 48000; > >>> channels->min =3D channels->max =3D 2; > >>> snd_mask_none(fmt); > >>> snd_mask_set_format(fmt, pcm_fmt); > >>> } > >>> > >>> Pierre, thoughts? > >> > >> thanks Harsha, that looks like what I had in mind, but my earlier ques= tion was > >> why we deal with the rates and formats only in the last case? > > The speaker codec supported only 16 bit. (Vendor mentioned) > > For playback on this platform, only 48Khz was used. > > ok then, as long as Harsha and Lukasz are aligned I'm fine. Thanks! >