From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOUWa-0003o7-Tu for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:23:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOUWU-0007eZ-3U for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:23:08 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:34949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOUWT-0007eR-Rb for qemu-devel@nongnu.org; Wed, 17 Oct 2012 10:23:02 -0400 Received: by mail-lb0-f173.google.com with SMTP id gj3so4845114lbb.4 for ; Wed, 17 Oct 2012 07:23:00 -0700 (PDT) MIME-Version: 1.0 Sender: alex.barcelo@gmail.com In-Reply-To: References: <1348935086-11336-1-git-send-email-abarcelo@ac.upc.edu> From: Alex Barcelo Date: Wed, 17 Oct 2012 16:22:40 +0200 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , qemu-devel@nongnu.org Thanks Peter for all the feedback! I have just sent the v2 (have been on holiday this weekend, a bit offline). I hope that this one is a better patch. Sorry Riku, I have doubleposted the new patch to you, I slipped on the git send-email command, and sent the patch only to you at first (not to the list). I corrected it but now you may have received twice. Next time I will double check my git output :( On Wed, Oct 10, 2012 at 5:37 PM, Peter Maydell wrote: > On 8 October 2012 19:42, Alex Barcelo wrote: >> okay, now I see that this lacks a lot of "presentation". > >> Before sending a v2, is there something more that I should correct? > > Well, yes, your cover letter could be a little more verbose, but I > think mostly it's just that nobody's got round to reviewing the > patches yet. I'll have a look at them in a moment. > > One thing that is definitely missing and is critical is that > you need to include a Signed-off-by: line in your patches' > commit messages: we cannot commit them without one. > (http://wiki.qemu.org/Contribute/SubmitAPatch mentions this and > has some other hints, if you haven't read it.) > >> And one netiquete question, test-breaking code should be in the >> description (cover, 00/00)? On a next post in the same thread? Another >> thread? > > In the cover letter is fine. > > -- PMM