From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG3xD-0005VY-Er for qemu-devel@nongnu.org; Tue, 08 May 2018 10:51:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG3x7-0005L8-GK for qemu-devel@nongnu.org; Tue, 08 May 2018 10:50:59 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:32802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG3x7-0005KN-98 for qemu-devel@nongnu.org; Tue, 08 May 2018 10:50:53 -0400 Received: by mail-qk0-x244.google.com with SMTP id c11so1200350qkm.0 for ; Tue, 08 May 2018 07:50:50 -0700 (PDT) MIME-Version: 1.0 Sender: dunlapg@gmail.com In-Reply-To: <20180504210001.GB30250@redhat.com> References: <20180504160026.14017-1-berrange@redhat.com> <20180504210001.GB30250@redhat.com> From: George Dunlap Date: Tue, 8 May 2018 15:50:49 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, xen-devel , Peter Maydell , Thomas Huth , Michael Roth , Stefan Berger , Olaf Hering , Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini , Eric Blake , Ian Jackson , Jan Beulich , Juergen Gross , Anthony Perard On Fri, May 4, 2018 at 10:00 PM, Daniel P. Berrang=C3=A9 wrote: > CC'ing xen-devel in case Xen maintainers have a need for something that > will that conflict with this proposal wrt supported build platforms. Thanks for the heads-up. CC'ing some more people who usually have opinions on this sort of thing. > > On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrang=C3=A9 wrote: >> This short series is a followup the discussions around min glib version >> when Olaf found we had accidentally increased the min glib by using a >> newer function: >> >> https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02699.html >> >> Some key points from that thread >> >> - Although we have a docker job that tries to test the min glib >> version is adhered to, that's only run post-build, not by Peter's >> merge tests, nor by patchew. >> >> - The docker min glib test failed to detect the problem anyway >> because RHEL had backported the symbol in question. >> >> - The docker min glib test only builds with certain configure >> options so isn't foolproof. >> >> - The modern distros we implicitly care about have way newer glib >> than 2.22 >> >> - Peter's OS-X build host previously had 2.22, but after switching >> from fink to homebrew now has 2.56 >> >> - I suggested following libvirt's lead in writing a policy for how >> we pick supported OS targets to inform maintainers when min versions >> can be increased. >> >> This series writes such a document largely based on one I wrote for >> libvirt with a few changes, largely around OS-X and *BSD. Note it >> is not meant to be an exhaustive list of distros we'll build on, rather >> a representative selection, so that we can identify the range of 3rd >> party library versions we need to care about. So if your favourite >> distro is missing, dont be alarmed, as it probably ships similar >> vintage software to one of those listed - if not feel free to suggest >> additions. >> >> Based on that doc and https://repology.org/metapackage/glib/versions, >> I identified that we could feasibly set min glib to 2.42. Note that >> this would be dropping RHEL-6 as a build host (RHEL-6.0 came out in >> 2010 so that's reasonable to drop IMHO). It would still cover 2 major >> Debian versions and 2 most recent Ubuntu LTS (16.04, 18.04, but *not* >> 14.04). This min glib lets us remove almost all our compat code. >> >> Most interestingly, thanks tothe new min version being greater than >> 2.32, we can now use GLIB_VERSION_MAX_ALLOWED to validate the correct >> API usage according to our min version: >> >> https://developer.gnome.org/glib/stable/glib-Version-Information.html#= GLIB-VERSION-MAX-ALLOWED:CAPS >> >> This means that *all* our CI jobs & developer builds will be enforcing >> the min version, so means very many more conditionally built features >> will get their build validated against min glib version. This would >> do a much better job of catching mistakes than our min-glib docker >> job, making that obsolete. >> >> Daniel P. Berrang=C3=A9 (3): >> qemu-doc: provide details of supported build platforms >> glib: bump min required glib library version to 2.42 >> glib: enforce the minimum required version and warn about old APIs Two responses from me. With my Xen maintainer hat on: I wouldn't feel justified, personally, in asking another project to continue supporting older versions. If we didn't want to bump our own glib version, we would have to disable "upstream" QEMU (as opposed to Xen's old qemu fork) for older versions of glib. That said, when we've had similar discussions for our own project, we've generally aimed at supporting all major currently-supported distros, which would include RHEL 6 / CentOS 6. Tailing into that, with my CentOS package maintainer hat on: You said that the code in question compiled on RHEL 6 because RH had backported the function in question. Will QEMU continue to actually compile on RHEL 6 / CentOS 6? I.e., will configure be checking for that function, or only checking for the version number? If the former, then the CentOS 6 Xen packages won't be affected. If the latter, then at some point I'll have to stop updating the Xen version for CentOS 6 -- but as the CentOS 6 EOL is coming up in 2020, it shouldn't be too much of a hardship. -George From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 Date: Tue, 8 May 2018 15:50:49 +0100 Message-ID: References: <20180504160026.14017-1-berrange@redhat.com> <20180504210001.GB30250@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fG3x6-0005oG-Ce for xen-devel@lists.xenproject.org; Tue, 08 May 2018 14:50:52 +0000 Received: by mail-qk0-x242.google.com with SMTP id z8so24870106qki.11 for ; Tue, 08 May 2018 07:50:50 -0700 (PDT) In-Reply-To: <20180504210001.GB30250@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: Juergen Gross , Peter Maydell , Thomas Huth , Jan Beulich , Stefan Berger , Markus Armbruster , Ian Jackson , Michael Roth , qemu-devel@nongnu.org, Olaf Hering , Stefan Hajnoczi , Paolo Bonzini , Anthony Perard , xen-devel , Eric Blake List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBNYXkgNCwgMjAxOCBhdCAxMDowMCBQTSwgRGFuaWVsIFAuIEJlcnJhbmfDqSA8YmVy cmFuZ2VAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gQ0MnaW5nIHhlbi1kZXZlbCBpbiBjYXNlIFhlbiBt YWludGFpbmVycyBoYXZlIGEgbmVlZCBmb3Igc29tZXRoaW5nIHRoYXQKPiB3aWxsIHRoYXQgY29u ZmxpY3Qgd2l0aCB0aGlzIHByb3Bvc2FsIHdydCBzdXBwb3J0ZWQgYnVpbGQgcGxhdGZvcm1zLgoK VGhhbmtzIGZvciB0aGUgaGVhZHMtdXAuICBDQydpbmcgc29tZSBtb3JlIHBlb3BsZSB3aG8gdXN1 YWxseSBoYXZlCm9waW5pb25zIG9uIHRoaXMgc29ydCBvZiB0aGluZy4KCj4KPiBPbiBGcmksIE1h eSAwNCwgMjAxOCBhdCAwNTowMDoyM1BNICswMTAwLCBEYW5pZWwgUC4gQmVycmFuZ8OpIHdyb3Rl Ogo+PiBUaGlzIHNob3J0IHNlcmllcyBpcyBhIGZvbGxvd3VwIHRoZSBkaXNjdXNzaW9ucyBhcm91 bmQgbWluIGdsaWIgdmVyc2lvbgo+PiB3aGVuIE9sYWYgZm91bmQgd2UgaGFkIGFjY2lkZW50YWxs eSBpbmNyZWFzZWQgdGhlIG1pbiBnbGliIGJ5IHVzaW5nIGEKPj4gbmV3ZXIgZnVuY3Rpb246Cj4+ Cj4+ICAgaHR0cHM6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUvaHRtbC9xZW11LWRldmVsLzIwMTgt MDQvbXNnMDI2OTkuaHRtbAo+Pgo+PiBTb21lIGtleSBwb2ludHMgZnJvbSB0aGF0IHRocmVhZAo+ Pgo+PiAgIC0gQWx0aG91Z2ggd2UgaGF2ZSBhIGRvY2tlciBqb2IgdGhhdCB0cmllcyB0byB0ZXN0 IHRoZSBtaW4gZ2xpYgo+PiAgICAgdmVyc2lvbiBpcyBhZGhlcmVkIHRvLCB0aGF0J3Mgb25seSBy dW4gcG9zdC1idWlsZCwgbm90IGJ5IFBldGVyJ3MKPj4gICAgIG1lcmdlIHRlc3RzLCBub3IgYnkg cGF0Y2hldy4KPj4KPj4gICAtIFRoZSBkb2NrZXIgbWluIGdsaWIgdGVzdCBmYWlsZWQgdG8gZGV0 ZWN0IHRoZSBwcm9ibGVtIGFueXdheQo+PiAgICAgYmVjYXVzZSBSSEVMIGhhZCBiYWNrcG9ydGVk IHRoZSBzeW1ib2wgaW4gcXVlc3Rpb24uCj4+Cj4+ICAgLSBUaGUgZG9ja2VyIG1pbiBnbGliIHRl c3Qgb25seSBidWlsZHMgd2l0aCBjZXJ0YWluIGNvbmZpZ3VyZQo+PiAgICAgb3B0aW9ucyBzbyBp c24ndCBmb29scHJvb2YuCj4+Cj4+ICAgLSBUaGUgbW9kZXJuIGRpc3Ryb3Mgd2UgaW1wbGljaXRs eSBjYXJlIGFib3V0IGhhdmUgd2F5IG5ld2VyIGdsaWIKPj4gICAgIHRoYW4gMi4yMgo+Pgo+PiAg IC0gUGV0ZXIncyBPUy1YIGJ1aWxkIGhvc3QgcHJldmlvdXNseSBoYWQgMi4yMiwgYnV0IGFmdGVy IHN3aXRjaGluZwo+PiAgICAgZnJvbSBmaW5rIHRvIGhvbWVicmV3IG5vdyBoYXMgMi41Ngo+Pgo+ PiAgIC0gSSBzdWdnZXN0ZWQgZm9sbG93aW5nIGxpYnZpcnQncyBsZWFkIGluIHdyaXRpbmcgYSBw b2xpY3kgZm9yIGhvdwo+PiAgICAgd2UgcGljayBzdXBwb3J0ZWQgT1MgdGFyZ2V0cyB0byBpbmZv cm0gbWFpbnRhaW5lcnMgd2hlbiBtaW4gdmVyc2lvbnMKPj4gICAgIGNhbiBiZSBpbmNyZWFzZWQu Cj4+Cj4+IFRoaXMgc2VyaWVzIHdyaXRlcyBzdWNoIGEgZG9jdW1lbnQgbGFyZ2VseSBiYXNlZCBv biBvbmUgSSB3cm90ZSBmb3IKPj4gbGlidmlydCB3aXRoIGEgZmV3IGNoYW5nZXMsIGxhcmdlbHkg YXJvdW5kIE9TLVggYW5kICpCU0QuIE5vdGUgaXQKPj4gaXMgbm90IG1lYW50IHRvIGJlIGFuIGV4 aGF1c3RpdmUgbGlzdCBvZiBkaXN0cm9zIHdlJ2xsIGJ1aWxkIG9uLCByYXRoZXIKPj4gYSByZXBy ZXNlbnRhdGl2ZSBzZWxlY3Rpb24sIHNvIHRoYXQgd2UgY2FuIGlkZW50aWZ5IHRoZSByYW5nZSBv ZiAzcmQKPj4gcGFydHkgbGlicmFyeSB2ZXJzaW9ucyB3ZSBuZWVkIHRvIGNhcmUgYWJvdXQuIFNv IGlmIHlvdXIgZmF2b3VyaXRlCj4+IGRpc3RybyBpcyBtaXNzaW5nLCBkb250IGJlIGFsYXJtZWQs IGFzIGl0IHByb2JhYmx5IHNoaXBzIHNpbWlsYXIKPj4gdmludGFnZSBzb2Z0d2FyZSB0byBvbmUg b2YgdGhvc2UgbGlzdGVkIC0gaWYgbm90IGZlZWwgZnJlZSB0byBzdWdnZXN0Cj4+IGFkZGl0aW9u cy4KPj4KPj4gQmFzZWQgb24gdGhhdCBkb2MgYW5kIGh0dHBzOi8vcmVwb2xvZ3kub3JnL21ldGFw YWNrYWdlL2dsaWIvdmVyc2lvbnMsCj4+IEkgaWRlbnRpZmllZCB0aGF0IHdlIGNvdWxkIGZlYXNp Ymx5IHNldCBtaW4gZ2xpYiB0byAyLjQyLiBOb3RlIHRoYXQKPj4gdGhpcyB3b3VsZCBiZSBkcm9w cGluZyBSSEVMLTYgYXMgYSBidWlsZCBob3N0IChSSEVMLTYuMCBjYW1lIG91dCBpbgo+PiAyMDEw IHNvIHRoYXQncyByZWFzb25hYmxlIHRvIGRyb3AgSU1ITykuIEl0IHdvdWxkIHN0aWxsIGNvdmVy IDIgbWFqb3IKPj4gRGViaWFuIHZlcnNpb25zIGFuZCAyIG1vc3QgcmVjZW50IFVidW50dSBMVFMg KDE2LjA0LCAxOC4wNCwgYnV0ICpub3QqCj4+IDE0LjA0KS4gVGhpcyBtaW4gZ2xpYiBsZXRzIHVz IHJlbW92ZSBhbG1vc3QgYWxsIG91ciBjb21wYXQgY29kZS4KPj4KPj4gTW9zdCBpbnRlcmVzdGlu Z2x5LCB0aGFua3MgdG90aGUgbmV3IG1pbiB2ZXJzaW9uIGJlaW5nIGdyZWF0ZXIgdGhhbgo+PiAy LjMyLCB3ZSBjYW4gbm93IHVzZSBHTElCX1ZFUlNJT05fTUFYX0FMTE9XRUQgdG8gdmFsaWRhdGUg dGhlIGNvcnJlY3QKPj4gQVBJIHVzYWdlIGFjY29yZGluZyB0byBvdXIgbWluIHZlcnNpb246Cj4+ Cj4+ICAgaHR0cHM6Ly9kZXZlbG9wZXIuZ25vbWUub3JnL2dsaWIvc3RhYmxlL2dsaWItVmVyc2lv bi1JbmZvcm1hdGlvbi5odG1sI0dMSUItVkVSU0lPTi1NQVgtQUxMT1dFRDpDQVBTCj4+Cj4+IFRo aXMgbWVhbnMgdGhhdCAqYWxsKiBvdXIgQ0kgam9icyAmIGRldmVsb3BlciBidWlsZHMgd2lsbCBi ZSBlbmZvcmNpbmcKPj4gdGhlIG1pbiB2ZXJzaW9uLCBzbyBtZWFucyB2ZXJ5IG1hbnkgbW9yZSBj b25kaXRpb25hbGx5IGJ1aWx0IGZlYXR1cmVzCj4+IHdpbGwgZ2V0IHRoZWlyIGJ1aWxkIHZhbGlk YXRlZCBhZ2FpbnN0IG1pbiBnbGliIHZlcnNpb24uIFRoaXMgd291bGQKPj4gZG8gYSBtdWNoIGJl dHRlciBqb2Igb2YgY2F0Y2hpbmcgbWlzdGFrZXMgdGhhbiBvdXIgbWluLWdsaWIgZG9ja2VyCj4+ IGpvYiwgbWFraW5nIHRoYXQgb2Jzb2xldGUuCj4+Cj4+IERhbmllbCBQLiBCZXJyYW5nw6kgKDMp Ogo+PiAgIHFlbXUtZG9jOiBwcm92aWRlIGRldGFpbHMgb2Ygc3VwcG9ydGVkIGJ1aWxkIHBsYXRm b3Jtcwo+PiAgIGdsaWI6IGJ1bXAgbWluIHJlcXVpcmVkIGdsaWIgbGlicmFyeSB2ZXJzaW9uIHRv IDIuNDIKPj4gICBnbGliOiBlbmZvcmNlIHRoZSBtaW5pbXVtIHJlcXVpcmVkIHZlcnNpb24gYW5k IHdhcm4gYWJvdXQgb2xkIEFQSXMKClR3byByZXNwb25zZXMgZnJvbSBtZS4KCldpdGggbXkgWGVu IG1haW50YWluZXIgaGF0IG9uOiBJIHdvdWxkbid0IGZlZWwganVzdGlmaWVkLCBwZXJzb25hbGx5 LAppbiBhc2tpbmcgYW5vdGhlciBwcm9qZWN0IHRvIGNvbnRpbnVlIHN1cHBvcnRpbmcgb2xkZXIg dmVyc2lvbnMuICBJZgp3ZSBkaWRuJ3Qgd2FudCB0byBidW1wIG91ciBvd24gZ2xpYiB2ZXJzaW9u LCB3ZSB3b3VsZCBoYXZlIHRvIGRpc2FibGUKInVwc3RyZWFtIiBRRU1VIChhcyBvcHBvc2VkIHRv IFhlbidzIG9sZCBxZW11IGZvcmspIGZvciBvbGRlciB2ZXJzaW9ucwpvZiBnbGliLgoKVGhhdCBz YWlkLCB3aGVuIHdlJ3ZlIGhhZCBzaW1pbGFyIGRpc2N1c3Npb25zIGZvciBvdXIgb3duIHByb2pl Y3QsCndlJ3ZlIGdlbmVyYWxseSBhaW1lZCBhdCBzdXBwb3J0aW5nIGFsbCBtYWpvciBjdXJyZW50 bHktc3VwcG9ydGVkCmRpc3Ryb3MsIHdoaWNoIHdvdWxkIGluY2x1ZGUgUkhFTCA2IC8gQ2VudE9T IDYuCgpUYWlsaW5nIGludG8gdGhhdCwgd2l0aCBteSBDZW50T1MgcGFja2FnZSBtYWludGFpbmVy IGhhdCBvbjogWW91IHNhaWQKdGhhdCB0aGUgY29kZSBpbiBxdWVzdGlvbiBjb21waWxlZCBvbiBS SEVMIDYgYmVjYXVzZSBSSCBoYWQgYmFja3BvcnRlZAp0aGUgZnVuY3Rpb24gaW4gcXVlc3Rpb24u ICBXaWxsIFFFTVUgY29udGludWUgdG8gYWN0dWFsbHkgY29tcGlsZSBvbgpSSEVMIDYgLyBDZW50 T1MgNj8gIEkuZS4sIHdpbGwgY29uZmlndXJlIGJlIGNoZWNraW5nIGZvciB0aGF0CmZ1bmN0aW9u LCBvciBvbmx5IGNoZWNraW5nIGZvciB0aGUgdmVyc2lvbiBudW1iZXI/CgpJZiB0aGUgZm9ybWVy LCB0aGVuIHRoZSBDZW50T1MgNiBYZW4gcGFja2FnZXMgd29uJ3QgYmUgYWZmZWN0ZWQuICBJZgp0 aGUgbGF0dGVyLCB0aGVuIGF0IHNvbWUgcG9pbnQgSSdsbCBoYXZlIHRvIHN0b3AgdXBkYXRpbmcg dGhlIFhlbgp2ZXJzaW9uIGZvciBDZW50T1MgNiAtLSBidXQgYXMgdGhlIENlbnRPUyA2IEVPTCBp cyBjb21pbmcgdXAgaW4gMjAyMCwKaXQgc2hvdWxkbid0IGJlIHRvbyBtdWNoIG9mIGEgaGFyZHNo aXAuCgogLUdlb3JnZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5v cmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZl bA==