From: George Dunlap <george.dunlap@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Ronald Rojas <ronladred@gmail.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY
Date: Tue, 14 Feb 2017 12:23:46 +0000 [thread overview]
Message-ID: <CAFLBxZYQyaR6BhY6-JMdAf-wrfHBPjG_WD10Nuiubzg9wCWobQ@mail.gmail.com> (raw)
In-Reply-To: <20170214102939.naadxznhfzo54455@citrix.com>
On Tue, Feb 14, 2017 at 10:29 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> On Thu, Feb 09, 2017 at 11:35:16AM +0000, George Dunlap wrote:
>> No. This is why I'm bothering to paint this bikeshed: In every context
>> *except* "cpupool create", 0 means cpupool0 -- the one that was created
>> at boot, which always contains dom0, and which cannot be destroyed.
>> (You can only remove all but one of the cpus.) If you remove a cpupool
>> from poolid 0, you remove it from cpupool0, not "any" pool. If you
>> create a domain and ask to put it in poolid 0, it will be put in
>> cpupool0, not "any" pool. The only context in which "0" currently means
>> "any" is when you're creating a cpupool.
>>
>
> OK. This makes sense.
>
[snip]
>> > I want to reserve the possibility to change that into an enum in the
>> > future.
>>
>> Yes, I had thought of that -- but like I said, I thought enums were
>> meant mostly for things for which there was an exhaustive list. In this
>> case it's a "magic" value for a parameter which normally has a plain
>> numerical meaning.
>>
>> But I can add the #define if you wish.
>>
>
> You don't need to do that.
Is that an Ack? :-)
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-14 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 14:51 [PATCH 1/2] tools/libxc: Introduce XC_CPUPOOL_POOLID_ANY George Dunlap
2017-02-08 14:51 ` [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY George Dunlap
2017-02-08 16:11 ` Dario Faggioli
2017-02-08 16:17 ` George Dunlap
2017-02-09 10:35 ` Wei Liu
2017-02-09 11:17 ` George Dunlap
2017-02-09 11:24 ` Wei Liu
2017-02-09 11:35 ` George Dunlap
2017-02-14 10:29 ` Wei Liu
2017-02-14 12:23 ` George Dunlap [this message]
2017-02-08 16:03 ` [PATCH 1/2] tools/libxc: Introduce XC_CPUPOOL_POOLID_ANY Dario Faggioli
2017-02-09 10:36 ` Wei Liu
2017-02-14 16:57 ` Wei Liu
2017-02-15 17:08 George Dunlap
2017-02-15 17:08 ` [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZYQyaR6BhY6-JMdAf-wrfHBPjG_WD10Nuiubzg9wCWobQ@mail.gmail.com \
--to=george.dunlap@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jgross@suse.com \
--cc=ronladred@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.