All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <dunlapg@umich.edu>
To: Juergen Gross <jgross@suse.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	stable <stable@vger.kernel.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: Patches for stable
Date: Thu, 5 Apr 2018 11:06:09 +0100	[thread overview]
Message-ID: <CAFLBxZYpTSfkJ3KJg2-M5Pn5y_DiYzOaebCE8f3TkJD8XCOzrA__11655.4615823135$1522922710$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <d1b13a66-f31a-558c-7935-340e71bfa9a9@suse.com>

On Thu, Apr 5, 2018 at 9:00 AM, Juergen Gross <jgross@suse.com> wrote:
>> These are not just "patches to fix the issue", they are "patches to add
>> new features" that touch core acpi bits, right?  Support for new
>> hardware and platforms and such are not normally part of the stable
>> kernel patches at all (with the exceptions of tiny patches that add
>> device ids and quirks.)
>
> The way the patches are written are the result of requests of the
> maintainers (x86, acpi). This way they don't break layering of the
> components. I'd be happy to rewrite them for stable kernels if you
> like that better.
>
>> That's my main objection here, combined with the obvious one of "Xen
>> does not care about their users".
>
> Xen does care. PVH support in Linux is relatively new (the first working
> kernel was 4.11), Xen has full PVH guest support since Xen 4.10.
>
> For being able to replace PV mode it is mandatory for PVH to not add
> unnecessary performance overhead, as performance is the main reason for
> customers to run their guests in PV mode (yes, PV guests _are_ faster,
> especially with many vcpus).

I'm afraid I have to agree with Greg here regarding the meaning of
"supported"; and I remember expressing a similar sentiment when I
discovered that a recent Linux kernel wouldn't boot on the development
version of Xen.  Either we declare PVH in Linux 4.11-4.16 as
"supported", in which case we have to maintain backwards compatibility
and attempt not to break it; or we declare PVH in Linux 4.11-4.16 as
"tech preview" (retroactively), and Greg should feel free to ignore
these backports.

It's unfortunate that Linux 4.11 didn't follow the spec, but whose
fault is that?

The fact is, that as it stands, a user could have a perfectly working
system with Xen 4.10 and a load of PVH guests running stock Linux
4.15, and then upgrade to Xen 4.11 and have all those guests break for
no apparent reason.  That's a pretty obnoxious thing to do,
particularly as we made such a fanfare about Xen 4.10 finally having
PVH support, and encouraging everyone to go and use it.  How are all
of those users going to feel about Xen?

Aren't there flags in the binary somewhere that could tell the
toolstack / Xen whether the kernel in question needs the RSDP table in
lowmem, or whether it can be put higher?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-04-05 10:06 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 10:38 Patches for stable Juergen Gross
2018-04-04 14:27 ` Greg KH
2018-04-04 14:27 ` Greg KH
2018-04-04 14:30   ` Juergen Gross
2018-04-04 14:46     ` Greg KH
2018-04-04 15:12       ` Juergen Gross
2018-04-04 15:12       ` Juergen Gross
2018-04-04 15:42         ` Greg KH
2018-04-04 16:32           ` Juergen Gross
2018-04-04 16:32           ` Juergen Gross
2018-04-05  6:33             ` Greg KH
2018-04-05  7:02               ` Juergen Gross
2018-04-05  7:14                 ` Greg KH
2018-04-05  7:14                 ` Greg KH
2018-04-05  8:00                   ` Juergen Gross
2018-04-05  8:00                   ` [Xen-devel] " Juergen Gross
2018-04-05 10:06                     ` George Dunlap [this message]
2018-04-05 10:06                     ` George Dunlap
2018-04-05 10:15                       ` George Dunlap
2018-04-05 10:15                       ` [Xen-devel] " George Dunlap
2018-04-05 12:19                       ` Juergen Gross
2018-04-05 12:19                       ` [Xen-devel] " Juergen Gross
2018-04-05 13:00                         ` Boris Ostrovsky
2018-04-05 13:00                         ` [Xen-devel] " Boris Ostrovsky
2018-04-05 13:06                           ` Juergen Gross
2018-04-05 13:06                           ` [Xen-devel] " Juergen Gross
2018-04-05 13:42                             ` George Dunlap
2018-04-05 13:42                             ` [Xen-devel] " George Dunlap
2018-04-05 14:09                               ` Juergen Gross
2018-04-05 14:56                                 ` George Dunlap
2018-04-05 14:56                                 ` [Xen-devel] " George Dunlap
2018-04-05 17:11                                   ` Juergen Gross
2018-04-05 18:33                                     ` Boris Ostrovsky
2018-04-06  8:00                                       ` Juergen Gross
2018-04-06  9:38                                         ` George Dunlap
2018-04-06  9:49                                       ` George Dunlap
2018-04-06 10:02                                         ` Juergen Gross
2018-04-06 10:07                                           ` George Dunlap
2018-04-06 10:57                                             ` Juergen Gross
2018-04-06 11:13                                               ` George Dunlap
2018-04-06 13:12                                                 ` Juergen Gross
2018-04-06 13:33                                                   ` George Dunlap
2018-04-06 14:10                                                     ` Boris Ostrovsky
2018-04-06 15:15                                                       ` Juergen Gross
2018-04-06 10:13                                     ` George Dunlap
2018-04-06 10:44                                       ` Juergen Gross
2018-04-05 14:09                               ` Juergen Gross
2018-04-05 20:20                 ` Thomas Backlund
2018-04-05 20:20                 ` Thomas Backlund
2018-04-05  7:02               ` Juergen Gross
2018-04-05  6:33             ` Greg KH
2018-04-04 15:42         ` Greg KH
2018-04-04 14:46     ` Greg KH
2018-04-04 14:30   ` Juergen Gross
2018-04-04 10:38 Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFLBxZYpTSfkJ3KJg2-M5Pn5y_DiYzOaebCE8f3TkJD8XCOzrA__11655.4615823135$1522922710$gmane$org@mail.gmail.com' \
    --to=dunlapg@umich.edu \
    --cc=boris.ostrovsky@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgross@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.